From 0af1d4971dba1e55bd26b7f2caf15a5cc8dd707b Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 8 Jul 2026 03:47:07 +0000 Subject: [PATCH] Rename `namespace` parameter to avoid C++ keyword conflict The C99_compile CI job builds the extension with `-Werror -Wc2x-extensions`, which promotes the `-Wc++-keyword` diagnostic (enabled via `-Wc++-compat`) to an error. The `namespace` parameter of `rbs_intern_type_name` collides with a C++ keyword, so the build failed with: error: identifier 'namespace' conflicts with a C++ keyword [-Werror,-Wc++-keyword] Rename the parameter to `type_namespace` to keep the source C++-compatible. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_013PkLsC6iM8VJgTB3aCrcXh --- ext/rbs_extension/ast_translation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/rbs_extension/ast_translation.c b/ext/rbs_extension/ast_translation.c index 259211628..c164b694b 100644 --- a/ext/rbs_extension/ast_translation.c +++ b/ext/rbs_extension/ast_translation.c @@ -196,8 +196,8 @@ static VALUE rbs_intern_namespace(rbs_translation_context_t ctx, rbs_namespace_t return rb_funcallv(RBS_Namespace, intern_brackets(), 2, args); } -static VALUE rbs_intern_type_name(VALUE namespace, VALUE name) { - VALUE args[2] = { namespace, name }; +static VALUE rbs_intern_type_name(VALUE type_namespace, VALUE name) { + VALUE args[2] = { type_namespace, name }; return rb_funcallv(RBS_TypeName, intern_brackets(), 2, args); }