From a3b1f10dbc6afd313806e9c69244738f4c8b88b9 Mon Sep 17 00:00:00 2001 From: Earlopain <14981592+Earlopain@users.noreply.github.com> Date: Wed, 1 Apr 2026 13:00:37 +0200 Subject: [PATCH] Remove a warning from `discarded-qualifiers` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I've been seeing this for a while now: ``` ../../../../ext/prism/../../src/memchr.c: In function ‘pm_memchr’: ../../../../ext/prism/../../src/memchr.c:35:16: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 35 | return memchr(memory, character, number); | ^~~~~~ ``` --- include/prism/internal/memchr.h | 2 +- src/memchr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/prism/internal/memchr.h b/include/prism/internal/memchr.h index 63c738387d..6f6b0bca30 100644 --- a/include/prism/internal/memchr.h +++ b/include/prism/internal/memchr.h @@ -10,6 +10,6 @@ * we need to search for a character in a buffer that could be the trailing byte * of a multibyte character. */ -void * pm_memchr(const void *source, int character, size_t number, bool encoding_changed, const pm_encoding_t *encoding); +const void * pm_memchr(const void *source, int character, size_t number, bool encoding_changed, const pm_encoding_t *encoding); #endif diff --git a/src/memchr.c b/src/memchr.c index 6266d4ca7a..900e6245b7 100644 --- a/src/memchr.c +++ b/src/memchr.c @@ -11,7 +11,7 @@ * we need to search for a character in a buffer that could be the trailing byte * of a multibyte character. */ -void * +const void * pm_memchr(const void *memory, int character, size_t number, bool encoding_changed, const pm_encoding_t *encoding) { if (encoding_changed && encoding->multibyte && character >= TRAILING_BYTE_MINIMUM) { const uint8_t *source = (const uint8_t *) memory;