From 5d9b3b12b8f9c051067f318f555c9335ae2b1faf Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Tue, 16 Jun 2026 05:50:12 -0700 Subject: [PATCH] Fix unused variable 'moduleClass' in RCTTurboModuleManager.mm Summary: Pika 27 (LLVM 21 / Swift 6.4) flags `Class moduleClass = [module class];` as an unused variable (`-Werror,-Wunused-variable`) in `RCTTurboModuleManager.mm`. Its only reference is inside an `RCTLogError` call, which compiles to a no-op in release builds, leaving the variable unused. This inlines `[module class]` directly into the `RCTLogError` call and removes the local declaration. The expression is now elided together with the log macro in release builds, eliminating the dangling unused variable. Debug logging behavior is identical. No `#pragma` diagnostic suppression is used, per the task requirements. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=36a6fdd8-65cb-4fd8-bbc5-6d4afa5245dd) Reviewed By: javache Differential Revision: D108605640 --- .../core/platform/ios/ReactCommon/RCTTurboModuleManager.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm index c3eefd433636..0078a1a826a3 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm +++ b/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModuleManager.mm @@ -333,7 +333,6 @@ - (instancetype)initWithBridgeProxy:(RCTBridgeProxy *)bridgeProxy * Use respondsToSelector: below to infer conformance to @protocol(RCTTurboModule). Using conformsToProtocol: is * expensive. */ - Class moduleClass = [module class]; if ([module respondsToSelector:@selector(getTurboModule:)]) { ObjCTurboModule::InitParams params = { .moduleName = moduleName, @@ -345,7 +344,7 @@ - (instancetype)initWithBridgeProxy:(RCTBridgeProxy *)bridgeProxy auto turboModule = [(id)module getTurboModule:params]; if (turboModule == nullptr) { - RCTLogError(@"TurboModule \"%@\"'s getTurboModule: method returned nil.", moduleClass); + RCTLogError(@"TurboModule \"%@\"'s getTurboModule: method returned nil.", [module class]); } _turboModuleCache.insert({moduleName, turboModule});