Remove enableDifferentiatorMutationVectorPreallocation feature flag#57224
Closed
sammy-SC wants to merge 1 commit into
Closed
Remove enableDifferentiatorMutationVectorPreallocation feature flag#57224sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
Summary: The `enableDifferentiatorMutationVectorPreallocation` flag gated a mutation-vector pre-allocation optimization in the `Differentiator`. It was never ramped and is being removed. The flag defaulted to `false`, so this restores the pre-flag behavior by deleting the gated `reserve(...)` calls (an allocation hint with no effect on diffing results) and keeping the default `mutations.reserve(256)`. Removes the flag definition from `ReactNativeFeatureFlags.config.js`, the gated call sites in `Differentiator.cpp`, and the regenerated feature-flag files (via `yarn featureflags --update`). Changelog: [Internal] Reviewed By: javache Differential Revision: D108411519
meta-cla
Bot
added
the
CLA Signed
|
@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108411519. |
|
This pull request has been merged in 8634ecb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableDifferentiatorMutationVectorPreallocationflag gated a mutation-vector pre-allocation optimization in theDifferentiator. It was never ramped and is being removed. The flag defaulted tofalse, so this restores the pre-flag behavior by deleting the gatedreserve(...)calls (an allocation hint with no effect on diffing results) and keeping the defaultmutations.reserve(256).Removes the flag definition from
ReactNativeFeatureFlags.config.js, the gated call sites inDifferentiator.cpp, and the regenerated feature-flag files (viayarn featureflags --update).Changelog: [Internal]
Reviewed By: javache
Differential Revision: D108411519