Fix unused variable 'moduleClass' in RCTTurboModuleManager.mm#57221
Closed
sammy-SC wants to merge 1 commit into
Closed
Fix unused variable 'moduleClass' in RCTTurboModuleManager.mm#57221sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
Summary: Pika 27 (LLVM 21 / Swift 6.4) flags `Class moduleClass = [module class];` as an unused variable (`-Werror,-Wunused-variable`) in `RCTTurboModuleManager.mm`. Its only reference is inside an `RCTLogError` call, which compiles to a no-op in release builds, leaving the variable unused. This inlines `[module class]` directly into the `RCTLogError` call and removes the local declaration. The expression is now elided together with the log macro in release builds, eliminating the dangling unused variable. Debug logging behavior is identical. No `#pragma` diagnostic suppression is used, per the task requirements. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=36a6fdd8-65cb-4fd8-bbc5-6d4afa5245dd) Reviewed By: javache Differential Revision: D108605640
meta-cla
Bot
added
the
CLA Signed
|
@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108605640. |
|
This pull request has been merged in 25f6810. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pika 27 (LLVM 21 / Swift 6.4) flags
Class moduleClass = [module class];as an unused variable (-Werror,-Wunused-variable) inRCTTurboModuleManager.mm. Its only reference is inside anRCTLogErrorcall, which compiles to a no-op in release builds, leaving the variable unused.This inlines
[module class]directly into theRCTLogErrorcall and removes the local declaration. The expression is now elided together with the log macro in release builds, eliminating the dangling unused variable. Debug logging behavior is identical.No
#pragmadiagnostic suppression is used, per the task requirements.Session trajectory link
Reviewed By: javache
Differential Revision: D108605640