Skip to content

Comments

gh-142224: makeunicodedata.py: parse default bidi values#144815

Merged
serhiy-storchaka merged 5 commits intopython:mainfrom
StanFromIreland:unicodetata-bidis
Feb 18, 2026
Merged

gh-142224: makeunicodedata.py: parse default bidi values#144815
serhiy-storchaka merged 5 commits intopython:mainfrom
StanFromIreland:unicodetata-bidis

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Feb 14, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 14, 2026
Closed
serhiy-storchaka
serhiy-storchaka reviewed Feb 17, 2026
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to work on this issue next week, but you saved my time. Thank you.

@StanFromIreland
Updates for Serhiy
b665e66
@StanFromIreland
Merge branch 'main' into unicodetata-bidis
0262063 
# Conflicts:
#	Lib/test/test_unicodedata.py
#	Tools/unicode/makeunicodedata.py
serhiy-storchaka
serhiy-storchaka reviewed Feb 18, 2026
View reviewed changes
@malemburg
Copy link
Member

malemburg commented Feb 18, 2026

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

serhiy-storchaka
serhiy-storchaka approved these changes Feb 18, 2026
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit e49bfca into python:main Feb 18, 2026
51 checks passed
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 18, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 18, 2026

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 18, 2026

Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 18, 2026

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Feb 18, 2026

Sorry, @StanFromIreland and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e49bfca87cc188c271946491edc33831a901c7f1 3.14

@serhiy-storchaka serhiy-storchaka removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 18, 2026
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Feb 18, 2026

I am not sure if it is worth to backport this.

@StanFromIreland StanFromIreland deleted the unicodetata-bidis branch February 18, 2026 10:59
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Feb 18, 2026

Sorry, I don't have time for a true review. From a casual look, this LGTM, though.

No worries, thanks for the reviews.

I am not sure if it is worth to backport this.

Yes, I would think it is an uncommon issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@benjaminp benjaminp Awaiting requested review from benjaminp

@malemburg malemburg Awaiting requested review from malemburg

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @malemburg @serhiy-storchaka