review: move check before declaration

KowalskiThomas · KowalskiThomas · commit 876683f4f791 · 2026-05-11T10:47:48.000+02:00
diff --git a/Parser/lexer/lexer.c b/Parser/lexer/lexer.c
@@ -119,7 +119,6 @@ set_ftstring_expr(struct tok_state* tok, struct token *token, char c) {
     if (!(tok_mode->in_debug || tok_mode->string_kind == TSTRING) || token->metadata) {
         return 0;
     }
-    PyObject *res = NULL;
 
     Py_ssize_t expr_len = tok_mode->last_expr_size - tok_mode->last_expr_end;
     if (expr_len < 0) {
@@ -131,6 +130,8 @@ set_ftstring_expr(struct tok_state* tok, struct token *token, char c) {
         return -1;
     }
 
+    PyObject *res = NULL;
+
     // Look for a # character outside of string literals
     int hash_detected = 0;
     int in_string = 0;

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,6 @@ set_ftstring_expr(struct tok_state* tok, struct token *token, char c) {`
`119`	`119`	`if (!(tok_mode->in_debug \|\| tok_mode->string_kind == TSTRING) \|\| token->metadata) {`
`120`	`120`	`return 0;`
`121`	`121`	`}`
`122`		`- PyObject *res = NULL;`
`123`	`122`
`124`	`123`	`Py_ssize_t expr_len = tok_mode->last_expr_size - tok_mode->last_expr_end;`
`125`	`124`	`if (expr_len < 0) {`
`@@ -131,6 +130,8 @@ set_ftstring_expr(struct tok_state* tok, struct token *token, char c) {`
`131`	`130`	`return -1;`
`132`	`131`	`}`
`133`	`132`
	`133`	`+ PyObject *res = NULL;`
	`134`	`+`
`134`	`135`	`// Look for a # character outside of string literals`
`135`	`136`	`int hash_detected = 0;`
`136`	`137`	`int in_string = 0;`