Skip to content

Commit 3ada5d2

Browse files
committed
Address review comments
- Remove assert for None as that is not a possible return value anyway - Renamed verr to exc - Renamed digest to _ as it is ignored
1 parent 17eb629 commit 3ada5d2

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

Lib/test/test_hashlib.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -237,10 +237,9 @@ def test_algorithms_available(self):
237237
for name in hashlib.algorithms_available:
238238
with self.subTest(name):
239239
try:
240-
digest = hashlib.new(name, usedforsecurity=False)
241-
assert digest is not None
242-
except ValueError as verr:
243-
self.skip_if_blake2_not_builtin(name, verr)
240+
_ = hashlib.new(name, usedforsecurity=False)
241+
except ValueError as exc:
242+
self.skip_if_blake2_not_builtin(name, exc)
244243
raise
245244

246245
def test_usedforsecurity_true(self):
@@ -1102,8 +1101,8 @@ def test_threaded_hashing_fast(self):
11021101
with self.subTest(name):
11031102
try:
11041103
self.do_test_threaded_hashing(constructor, is_shake=False)
1105-
except ValueError as verr:
1106-
self.skip_if_blake2_not_builtin(name, verr)
1104+
except ValueError as exc:
1105+
self.skip_if_blake2_not_builtin(name, exc)
11071106
raise
11081107

11091108
if shake_128 := getattr(hashlib, 'shake_128', None):

0 commit comments

Comments
 (0)