Statement and StatementParser updates#1579
Merged
kmvanbrunt merged 5 commits intomainfrom Feb 19, 2026
Merged
Conversation
- Made Statement.arg_list a property which generates the list on-demand. - Renamed Statement.output to Statement.redirector. - Renamed Statement.output_to to Statement.redirect_to. - Removed Statement.pipe_to since it's data can be stored in Statement.redirector and Statement.redirect_to.
Contributor
|
🤖 Hi @kmvanbrunt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 22 22
Lines 4892 4892
=======================================
Hits 4864 4864
Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
🤖 I'm sorry @kmvanbrunt, but I was unable to process your request. Please see the logs for more details. |
tleonhardt
requested changes
Feb 19, 2026
tleonhardt
previously approved these changes
Feb 19, 2026
kmvanbrunt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statement Updates
Statement.multiline_commandfrom a string to a bool.Statement.arg_lista property which generates the list on-demand.Statement.outputtoStatement.redirector.Statement.output_totoStatement.redirect_to.Statement.pipe_tosince it can be handled byStatement.redirectorandStatement.redirect_to.StatementParser Updates
StatementParser.parse_command_only()to return aPartialStatementobject.