From e85c1a0aa4ff34d202ba686b3087ed59ff2151ea Mon Sep 17 00:00:00 2001 From: osulzhenko Date: Tue, 10 Feb 2026 18:38:38 +0200 Subject: [PATCH 1/3] Tests: Add http_method field to ExtRequestPrebidServer --- .../model/request/auction/Server.groovy | 1 + .../server/functional/tests/AmpSpec.groovy | 26 +++++++++++++++++++ .../functional/tests/AuctionSpec.groovy | 2 ++ 3 files changed, 29 insertions(+) diff --git a/src/test/groovy/org/prebid/server/functional/model/request/auction/Server.groovy b/src/test/groovy/org/prebid/server/functional/model/request/auction/Server.groovy index 280ef3c7550..c088163b38b 100644 --- a/src/test/groovy/org/prebid/server/functional/model/request/auction/Server.groovy +++ b/src/test/groovy/org/prebid/server/functional/model/request/auction/Server.groovy @@ -12,4 +12,5 @@ class Server { Integer gvlId String datacenter String endpoint + String httpMethod } diff --git a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy index 47e08555828..087417f293e 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy @@ -1,5 +1,6 @@ package org.prebid.server.functional.tests +import org.apache.http.client.methods.HttpGet import org.prebid.server.functional.model.db.StoredRequest import org.prebid.server.functional.model.db.StoredResponse import org.prebid.server.functional.model.request.amp.AmpRequest @@ -15,6 +16,7 @@ import org.prebid.server.functional.service.PrebidServerException import org.prebid.server.functional.util.PBSUtils import static io.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST +import static org.prebid.server.functional.model.bidder.BidderName.GENERIC import static org.prebid.server.functional.util.SystemProperties.PBS_VERSION class AmpSpec extends BaseSpec { @@ -258,4 +260,28 @@ class AmpSpec extends BaseSpec { assert !bidderRequest.user.ext.consentedProvidersSettingsCamelCase.consentedProviders assert !bidderRequest.user.ext.consentedProvidersSettings.consentedProviders } + + def "PBS should move and not populate certain fields when debug enabled"() { + given: "Default amp request" + def ampRequest = AmpRequest.defaultAmpRequest + + and: "Save storedRequest into DB" + def ampStoredRequest = BidRequest.defaultBidRequest.tap { + ext.prebid.aliases = [(PBSUtils.randomString): GENERIC] + } + def storedRequest = StoredRequest.getStoredRequest(ampRequest, ampStoredRequest) + storedRequestDao.save(storedRequest) + + when: "PBS processes amp request" + defaultPbsService.sendAmpRequest(ampRequest) + + then: "BidderRequest should contain endpoint in ext.prebid.server.endpoint instead of ext.prebid.pbs.endpoint" + def bidderRequest = bidder.getBidderRequest(ampStoredRequest.id) + assert bidderRequest?.ext?.prebid?.server?.endpoint == "/openrtb2/amp" + assert bidderRequest?.ext?.prebid?.server?.httpMethod == HttpGet.METHOD_NAME + assert !bidderRequest?.ext?.prebid?.pbs?.endpoint + + and: "BidderRequest shouldn't populate fields" + assert !bidderRequest.ext.prebid.aliases + } } diff --git a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy index 1506e2e0a4d..6470e69d875 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy @@ -1,5 +1,6 @@ package org.prebid.server.functional.tests +import org.apache.http.client.methods.HttpPost import org.prebid.server.functional.model.UidsCookie import org.prebid.server.functional.model.bidder.Generic import org.prebid.server.functional.model.config.AccountAuctionConfig @@ -330,6 +331,7 @@ class AuctionSpec extends BaseSpec { then: "BidderRequest should contain endpoint in ext.prebid.server.endpoint instead of ext.prebid.pbs.endpoint" def bidderRequest = bidder.getBidderRequest(bidRequest.id) assert bidderRequest?.ext?.prebid?.server?.endpoint == "/openrtb2/auction" + assert bidderRequest?.ext?.prebid?.server?.httpMethod == HttpPost.METHOD_NAME assert !bidderRequest?.ext?.prebid?.pbs?.endpoint and: "BidderRequest shouldn't populate fields" From db732e297a7180b154979708319df18dae7549e6 Mon Sep 17 00:00:00 2001 From: osulzhenko Date: Thu, 26 Feb 2026 13:43:21 +0200 Subject: [PATCH 2/3] update after review --- .../groovy/org/prebid/server/functional/tests/AmpSpec.groovy | 2 +- .../org/prebid/server/functional/tests/AuctionSpec.groovy | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy index 087417f293e..4c2a331550f 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy @@ -261,7 +261,7 @@ class AmpSpec extends BaseSpec { assert !bidderRequest.user.ext.consentedProvidersSettings.consentedProviders } - def "PBS should move and not populate certain fields when debug enabled"() { + def "PBS PBS should move endpoint metadata to ext.prebid.server and strip aliases in bidder request"() { given: "Default amp request" def ampRequest = AmpRequest.defaultAmpRequest diff --git a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy index 6470e69d875..b36a247aadd 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy @@ -319,7 +319,7 @@ class AuctionSpec extends BaseSpec { assert !bidderRequest.user } - def "PBS should move and not populate certain fields when debug enabled"() { + def "PBS should move endpoint metadata to ext.prebid.server and strip aliases in bidder request"() { given: "Default bid request with aliases" def bidRequest = BidRequest.defaultBidRequest.tap { ext.prebid.aliases = [(PBSUtils.randomString): GENERIC] From d1fc0b59753cd58e96bc16015b47d3ca4abeadb8 Mon Sep 17 00:00:00 2001 From: markiian Date: Mon, 2 Mar 2026 13:08:50 +0200 Subject: [PATCH 3/3] Update typos --- .../groovy/org/prebid/server/functional/tests/AmpSpec.groovy | 4 ++-- .../org/prebid/server/functional/tests/AuctionSpec.groovy | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy index 4c2a331550f..805204139ae 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AmpSpec.groovy @@ -261,7 +261,7 @@ class AmpSpec extends BaseSpec { assert !bidderRequest.user.ext.consentedProvidersSettings.consentedProviders } - def "PBS PBS should move endpoint metadata to ext.prebid.server and strip aliases in bidder request"() { + def "PBS should move endpoint metadata to ext.prebid.server and strip aliases in bidder request"() { given: "Default amp request" def ampRequest = AmpRequest.defaultAmpRequest @@ -281,7 +281,7 @@ class AmpSpec extends BaseSpec { assert bidderRequest?.ext?.prebid?.server?.httpMethod == HttpGet.METHOD_NAME assert !bidderRequest?.ext?.prebid?.pbs?.endpoint - and: "BidderRequest shouldn't populate fields" + and: "BidderRequest shouldn't populate aliases field" assert !bidderRequest.ext.prebid.aliases } } diff --git a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy index b36a247aadd..cd0a5f6631e 100644 --- a/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy +++ b/src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy @@ -334,7 +334,7 @@ class AuctionSpec extends BaseSpec { assert bidderRequest?.ext?.prebid?.server?.httpMethod == HttpPost.METHOD_NAME assert !bidderRequest?.ext?.prebid?.pbs?.endpoint - and: "BidderRequest shouldn't populate fields" + and: "BidderRequest shouldn't populate aliases field" assert !bidderRequest.ext.prebid.aliases }