pyright was added to make lint in #567, but it was immediately suppressed with a leading - in the Makefile so it doesn't fail the build. Currently there are 110 pyright errors. I believe these are all things that we at one point intended to enforce but are not currently doing so.
This issue is to do cleanup of those 110 errors, and then turn on real enforcement by removing the -
|
lint-%: |
|
$(RUNNER) 'black --check --diff rsconnect/' |
|
$(RUNNER) 'flake8 rsconnect/' |
|
$(RUNNER) 'flake8 tests/' |
|
# Temporarily use leading '-' so it will continue even if pyright finds issues. |
|
-$(RUNNER) 'pyright rsconnect/' |
pyright was added to
make lintin #567, but it was immediately suppressed with a leading-in the Makefile so it doesn't fail the build. Currently there are 110 pyright errors. I believe these are all things that we at one point intended to enforce but are not currently doing so.This issue is to do cleanup of those 110 errors, and then turn on real enforcement by removing the
-rsconnect-python/Makefile
Lines 59 to 64 in 19f5415