| " . __("Eco-responsibility fees (tax free)", "order") . ": | ";
echo "";
if ($canedit) {
@@ -1114,7 +1114,7 @@ public function showForm($ID, $options = [])
}
echo " | ";
- /* port price */
+ /* port price */
echo "" . __("Postage", "order") . ": | ";
echo "";
if ($canedit) {
@@ -1204,7 +1204,7 @@ public function showForm($ID, $options = [])
echo " | ";
if ($canedit) {
echo "";
- // Make a select box
+ // Make a select box
$criteria = [
'SELECT' => ['c.id', 'c.name', 'c.firstname'],
'FROM' => 'glpi_contacts AS c',
@@ -1287,7 +1287,7 @@ public function showForm($ID, $options = [])
echo " | ";
echo "
";
- /* account section */
+ /* account section */
echo "";
- //comments of order
+ //comments of order
echo "| " . __("Comments") . ": | ";
echo "";
if ($canedit) {
@@ -1813,7 +1813,7 @@ public function generateOrder($params)
$template = $params['template'];
$signature = $params['sign'];
- // Only allow filenames with .odt extension and no path traversal
+ // Only allow filenames with .odt extension and no path traversal
if (!preg_match('/^[a-zA-Z0-9_\-\.]+\.odt$/', $template)) {
throw new \RuntimeException("Invalid template name");
}
@@ -2006,7 +2006,7 @@ public function generateOrder($params)
$total_TTC_Article = $element['price_discounted'] * (1 + ($element['taxe'] / 100));
$articleValues['ATIPriceTotalArticle'] = Html::formatNumber($total_TTC_Article);
- // Set variables in odt segment
+ // Set variables in odt segment
foreach ($articleValues as $field => $val) {
try {
$article->setVars($field, $val, true, 'UTF-8');
@@ -2021,7 +2021,7 @@ public function generateOrder($params)
$prices = $PluginOrderOrder_Item->getAllPrices($ID);
- // total price (with postage)
+ // total price (with postage)
$tax = new PluginOrderOrderTax();
$tax->getFromDB($this->fields["plugin_order_ordertaxes_id"]);
@@ -2066,7 +2066,7 @@ public function generateOrder($params)
$values['title_conditions'] = __("Payment conditions", "order");
$values['payment_conditions'] = $name;
- // Set variables in odt template
+ // Set variables in odt template
foreach ($values as $field => $val) {
try {
$odf->setVars($field, $val, true, 'UTF-8');
@@ -2086,7 +2086,7 @@ public function generateOrder($params)
$message .= Html::convDateTime($_SESSION['glpi_currenttime']);
$message = str_replace(" ", "_", $message);
$outputfile = str_replace(".odt", $message . ".odt", $template);
- // We export the file
+ // We export the file
$odf->exportAsAttachedFile($outputfile);
}
}
@@ -2182,7 +2182,7 @@ public static function showForBudget($budgets_id)
//if state is cancel do not decremente total already use
if ($data['plugin_order_orderstates_id'] !== PluginOrderOrderState::CANCELED) {
- $total += $prices["priceHT"];
+ $total += $prices["priceHT"];
}
$link = Toolbox::getItemTypeFormURL(__CLASS__);
@@ -2243,15 +2243,15 @@ public function canStillUseBudget($input)
$budget = new Budget();
$budget->getFromDB($input['budgets_id']);
- //If no begin date on a budget : do not display a warning
+ //If no begin date on a budget : do not display a warning
if (empty($budget->fields['begin_date'])) {
return true;
} else {
- //There's a begin date and order date is prior to it
+ //There's a begin date and order date is prior to it
if ($input['order_date'] < $budget->getField('begin_date')) {
return false;
}
- //There's an end date and order date is above it
+ //There's an end date and order date is above it
if (
!empty($budget->fields['end_date'])
&& $input['order_date'] > $budget->getField('end_date')
@@ -2305,17 +2305,17 @@ public function isOverBudget($ID)
{
/** @var \DBmysql $DB */
global $DB;
- //Do not check if it's a template
+ //Do not check if it's a template
if ($this->fields['is_template']) {
return PluginOrderOrder::ORDER_IS_UNDER_BUDGET;
}
- // Compute all prices for BUDGET
+ // Compute all prices for BUDGET
$table = $this->getTable();
$query = "SELECT *
FROM `$table`
WHERE `budgets_id` = '{$this->fields['budgets_id']}'";
- // Get BUDGET
+ // Get BUDGET
$budget = new Budget();
if (!$budget->getFromDB($this->fields['budgets_id'])) {
return false;
@@ -2332,10 +2332,10 @@ public function isOverBudget($ID)
$total_HT += $prices["priceHT"] + $data['port_price'];
}
- // Compare BUDGET value to TOTAL_HT value
+ // Compare BUDGET value to TOTAL_HT value
if ($total_HT > $budget->getField('value')) {
return PluginOrderOrder::ORDER_IS_OVER_BUDGET;
- } else if ($total_HT == $budget->getField('value')) {
+ } elseif ($total_HT == $budget->getField('value')) {
return PluginOrderOrder::ORDER_IS_EQUAL_BUDGET;
} else {
return PluginOrderOrder::ORDER_IS_UNDER_BUDGET;
@@ -2442,9 +2442,9 @@ public static function cronComputeLateOrders($task)
$options['orders'] = $orders;
if (NotificationEvent::raiseEvent('duedate', new PluginOrderOrder(), $options)) {
if ($task) {
- $task->log(Dropdown::getDropdownName("glpi_entities", $entity)
- . " : $message\n");
- $task->addVolume(1);
+ $task->log(Dropdown::getDropdownName("glpi_entities", $entity)
+ . " : $message\n");
+ $task->addVolume(1);
} else {
Session::addMessageAfterRedirect(Dropdown::getDropdownName("glpi_entities", $entity) .
" : $message");
@@ -2452,7 +2452,7 @@ public static function cronComputeLateOrders($task)
$input["type"] = Alert::THRESHOLD;
$input["itemtype"] = 'PluginOrderOrder';
- // add alerts
+ // add alerts
foreach ($orders as $ID => $tmp) {
$input["items_id"] = $ID;
$alert->add($input);
@@ -2493,22 +2493,22 @@ public static function addDocumentCategory(Document $document)
}
}
- // Fomrat document name
+ // Fomrat document name
if (
isset($document->input['itemtype'])
&& $document->input['itemtype'] == __CLASS__
&& $document->input['documentcategories_id']
&& $config->canRenameDocuments()
) {
- // Get document category
+ // Get document category
$documentCategory = new PluginOrderDocumentCategory();
if (!$documentCategory->getFromDBByCrit(['documentcategories_id' => $document->input['documentcategories_id']])) {
$documentCategory->getEmpty();
}
- // Get order linked to document
+ // Get order linked to document
$document_item = new Document_Item();
if ($document_item->getFromDBByCrit(['documents_id' => $document->fields['id'], 'itemtype' => self::getType()])) {
- // Update document name
+ // Update document name
$order = new self();
$order->getFromDB($document_item->fields['items_id']);
$extension = explode('.', $document->fields['filename']);
@@ -2532,11 +2532,11 @@ public function getForbiddenStandardMassiveAction()
}
- /**
- * @since version 0.85
- *
- * @see CommonDBTM::showMassiveActionsSubForm()
- **/
+ /**
+ * @since version 0.85
+ *
+ * @see CommonDBTM::showMassiveActionsSubForm()
+ **/
public static function showMassiveActionsSubForm(MassiveAction $ma)
{
switch ($ma->getAction()) {
@@ -2569,11 +2569,11 @@ public function getSpecificMassiveActions($checkitem = null)
}
- /**
- * @since version 0.85
- *
- * @see CommonDBTM::processMassiveActionsForOneItemtype()
- **/
+ /**
+ * @since version 0.85
+ *
+ * @see CommonDBTM::processMassiveActionsForOneItemtype()
+ **/
public static function processMassiveActionsForOneItemtype(MassiveAction $ma, CommonDBTM $item, array $ids)
{
switch ($ma->getAction()) {
@@ -2588,7 +2588,7 @@ public static function processMassiveActionsForOneItemtype(MassiveAction $ma, Co
"entities_id" => $entities_id,
"update" => __('Update'),
]);
- $ma->itemDone($item->getType(), $id, MassiveAction::ACTION_OK);
+ $ma->itemDone($item->getType(), $id, MassiveAction::ACTION_OK);
}
}
return;
@@ -2597,9 +2597,9 @@ public static function processMassiveActionsForOneItemtype(MassiveAction $ma, Co
}
- //------------------------------------------------------------
- //--------------------Install / uninstall --------------------
- //------------------------------------------------------------
+ //------------------------------------------------------------
+ //--------------------Install / uninstall --------------------
+ //------------------------------------------------------------
public static function install(Migration $migration)
{
@@ -2611,7 +2611,7 @@ public static function install(Migration $migration)
$default_key_sign = DBConnection::getDefaultPrimaryKeySignOption();
$table = self::getTable();
- //Installation
+ //Installation
if (!$DB->tableExists($table) && !$DB->tableExists("glpi_plugin_order")) {
$migration->displayMessage("Installing $table");
@@ -2672,11 +2672,11 @@ public static function install(Migration $migration)
'mode' => CronTask::MODE_EXTERNAL
]);
} else {
- //Upgrade
+ //Upgrade
$migration->displayMessage("Upgrading $table");
if ($DB->tableExists('glpi_plugin_order')) {
- //Update to 1.1.0
+ //Update to 1.1.0
$migration->addField('glpi_plugin_order', "port_price", "FLOAT NOT NULL default '0'");
$migration->addField('glpi_plugin_order', "taxes", "FLOAT NOT NULL default '0'");
if ($DB->fieldExists("glpi_plugin_order", "numordersupplier")) {
@@ -2692,7 +2692,7 @@ public static function install(Migration $migration)
$migration->migrationOneTable('glpi_plugin_order');
}
- //1.2.0
+ //1.2.0
$domigration_itemtypes = false;
if ($DB->tableExists('glpi_plugin_order')) {
$migration->renameTable("glpi_plugin_order", $table);
@@ -2801,7 +2801,7 @@ public static function install(Migration $migration)
$migration->addKey($table, "is_deleted");
$migration->migrationOneTable($table);
- //Only migrate itemtypes when it's only necessary, otherwise it breaks upgrade procedure !
+ //Only migrate itemtypes when it's only necessary, otherwise it breaks upgrade procedure !
if ($domigration_itemtypes) {
Plugin::migrateItemType(
[3150 => 'PluginOrderOrder'],
@@ -2814,7 +2814,7 @@ public static function install(Migration $migration)
}
if ($DB->tableExists("glpi_plugin_order_budgets")) {
- //Manage budgets (here because class has been remove since 1.4.0)
+ //Manage budgets (here because class has been remove since 1.4.0)
$migration->changeField("glpi_plugin_order_budgets", "ID", "id", " int {$default_key_sign} NOT NULL auto_increment");
$migration->changeField(
"glpi_plugin_order_budgets",
@@ -2871,7 +2871,7 @@ public static function install(Migration $migration)
[]
);
- //Manage budgets migration before dropping the table
+ //Manage budgets migration before dropping the table
$budget = new Budget();
$matchings = [
'budgets_id' => 'id',
@@ -2893,11 +2893,11 @@ public static function install(Migration $migration)
$tmp['comment'] = Toolbox::addslashes_deep($tmp['comment']);
- //Budget already exists in the core: update it
+ //Budget already exists in the core: update it
if ($budget->getFromDB($data['budgets_id'])) {
$budget->update($tmp);
} else {
- //Budget doesn't exists in the core: create it
+ //Budget doesn't exists in the core: create it
unset($tmp['id']);
$budget->add($tmp);
}
@@ -2914,7 +2914,7 @@ public static function install(Migration $migration)
}
}
- //1.3.0
+ //1.3.0
$migration->addField(
$table,
"plugin_order_ordertypes_id",
@@ -2922,7 +2922,7 @@ public static function install(Migration $migration)
);
$migration->migrationOneTable($table);
- //1.4.0
+ //1.4.0
if (
$migration->changeField(
"glpi_plugin_order_orders",
@@ -2939,7 +2939,7 @@ public static function install(Migration $migration)
$migration->addField($table, "duedate", "DATETIME NULL");
$migration->migrationOneTable($table);
- //1.5.0
+ //1.5.0
if ($DB->tableExists("glpi_dropdown_plugin_order_status")) {
$DB->query("DROP TABLE `glpi_dropdown_plugin_order_status`") or die($DB->error());
}
@@ -2950,7 +2950,7 @@ public static function install(Migration $migration)
$migration->addField($table, 'plugin_order_billstates_id', "int {$default_key_sign} NOT NULL default 0");
- //1.5.2
+ //1.5.2
$migration->addField($table, 'deliverydate', "DATETIME NULL");
$migration->addField($table, "is_late", "TINYINT NOT NULL DEFAULT '0'");
$migration->addKey($table, "is_late");
@@ -2973,15 +2973,15 @@ public static function install(Migration $migration)
$migration->addField($table, "users_id_delivery", "INT {$default_key_sign} NOT NULL DEFAULT '0'");
$migration->addField($table, "groups_id_delivery", "INT {$default_key_sign} NOT NULL DEFAULT '0'");
- //1.7.0
+ //1.7.0
$migration->addField($table, "date_mod", "timestamp");
$migration->addKey($table, "date_mod");
- //1.7.2
+ //1.7.2
$migration->addField($table, "is_helpdesk_visible", "bool", ['value' => 1]);
$migration->migrationOneTable($table);
- //Displayprefs
+ //Displayprefs
$prefs = [1 => 1, 2 => 2, 4 => 4, 5 => 5, 6 => 6, 7 => 7, 10 => 10];
foreach ($prefs as $num => $rank) {
if (
@@ -2999,19 +2999,19 @@ public static function install(Migration $migration)
}
}
- //Remove unused notifications
+ //Remove unused notifications
$notification = new Notification();
$notification->deleteByCriteria([
'itemtype' => 'PluginOrderOrder_Item',
]);
- //2.7.0
+ //2.7.0
$migration->addField($table, "global_discount", "FLOAT NOT NULL default '0'");
- //2.7.3
+ //2.7.3
$migration->changeField($table, "plugin_order_billstates_id", "plugin_order_billstates_id", "int {$default_key_sign} NOT NULL DEFAULT 0");
- // Add ecotax fields if they don't exist
+ // Add ecotax fields if they don't exist
if (!$DB->fieldExists($table, 'ecotax_price')) {
$migration->addField(
$table,
@@ -3033,8 +3033,7 @@ public static function install(Migration $migration)
$migration->migrationOneTable($table);
}
- // Remove RIGHT_OPENTICKET
- /** @phpstan-ignore-next-line */
+ // Remove RIGHT_OPENTICKET
$right_openticket = self::RIGHT_OPENTICKET;
$DB->update(
ProfileRight::getTable(),
@@ -3062,10 +3061,10 @@ public static function uninstall()
$DB->query($query);
}
- //Old table name
+ //Old table name
$DB->query("DROP TABLE IF EXISTS `glpi_plugin_order`") or die($DB->error());
- //Current table name
+ //Current table name
$DB->query("DROP TABLE IF EXISTS `" . self::getTable() . "`") or die($DB->error());
}
diff --git a/phpstan.neon b/phpstan.neon
index adf2db65c1..8d862b4f93 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -16,7 +16,6 @@ parameters:
stubFiles:
- ../../stubs/glpi_constants.php
ignoreErrors:
- - '#Call to deprecated method query\(\) of class DBmysql:#'
- '#Path in include_once\(\) ".*?/files/_plugins/order/generate/custom\.php" is not a file or it does not exist\.#'
excludePaths:
- 'inc/referenceinjection.class.php'
|