Skip to content

Commit eed1074

Browse files
authored
Merge pull request #7843 from plotly/set-splom-axis-matches-dflt-true
Change `splom.axis.matches` default from `false` to `true`
2 parents 35dafc5 + 069901b commit eed1074

22 files changed

Lines changed: 14 additions & 14 deletions

draftlogs/7843_change.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Change `splom.axis.matches` default from `false` to `true` [[#7843](https://github.com/plotly/plotly.js/pull/7843)]

src/traces/splom/attributes.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,9 @@ module.exports = {
9090
].join(' ')
9191
},
9292

93-
// TODO make 'true' the default in v3?
9493
matches: {
9594
valType: 'boolean',
96-
dflt: false,
95+
dflt: true,
9796
editType: 'calc',
9897
description: [
9998
'Determines whether or not the x & y axes generated by this',

src/types/generated/schema.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10038,7 +10038,7 @@ export interface SplomData {
1003810038
axis?: {
1003910039
/**
1004010040
* Determines whether or not the x & y axes generated by this dimension match. Equivalent to setting the `matches` axis attribute in the layout with the correct axis id.
10041-
* @default false
10041+
* @default true
1004210042
*/
1004310043
matches?: boolean;
1004410044
/** Sets the axis type for this dimension's generated x and y axes. Note that the axis `type` values set in layout take precedence over this attribute. */

test/image/baselines/splom_0.png

-191 Bytes
Loading
-1.44 KB
Loading
-444 Bytes
Loading
-351 Bytes
Loading
-1.67 KB
Loading

test/image/baselines/splom_log.png

651 Bytes
Loading
-296 Bytes
Loading

0 commit comments

Comments
 (0)