fix(violin): prevent FP drift in KDE sampling loop (avoid underrun/overrun on tiny spans)

Author: Austin Martin

src/traces/violin/calc.js

@@ -50,7 +50,8 @@ module.exports = function calc(gd, trace) {
             var kde = helpers.makeKDE(cdi, trace, vals);
             cdi.density = new Array(n);
 
-            for(var k = 0, t = span[0]; t < (span[1] + step / 2); k++, t += step) {
+            for(var k = 0; k < n; k++) {
+                var t = span[0] + k * step;
                 var v = kde(t);
                 cdi.density[k] = {v: v, t: t};
                 maxKDE = Math.max(maxKDE, v);

test/jasmine/tests/violin_test.js

@@ -401,6 +401,20 @@ describe('Test violin calc:', function() {
         expect(cd.length).toBe(1, '# of violins');
         expect(cd[0].bandwidth).toBe(0, 'bandwidth');
     });
+
+    it('should produce exactly n density samples for tiny or near-equal spans', function() {
+        var cd = _calc({
+            type: 'violin',
+            x: [0, 0],
+            y: [0.5006312999999999, 0.5006313]
+        });
+        var cdi = cd[0];
+
+        var dist = cdi.span[1] - cdi.span[0];
+        var n = Math.ceil(dist / (cdi.bandwidth / 3));
+
+        expect(cdi.density.length).toBe(n);
+    });
 });
 
 describe('Test violin hover:', function() {