Split trait purity test into dedicated file with RequiresPhp 8.0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.php

@@ -569,7 +569,7 @@ public function testBug14563(): void
 	{
 		$this->reportMaybes = true;
 		$this->reportStatic = true;
-		$errors = [
+		$this->analyse([__DIR__ . '/data/bug-14563.php'], [
 			[
 				'Impure method Bug14563\ChildImpureOverridesPure::pure() overrides pure method Bug14563\Foo::pure().',
 				31,
@@ -582,42 +582,44 @@ public function testBug14563(): void
 				'Impure method Bug14563\ImpureChildOfAllMethodsPure::method() overrides pure method Bug14563\AllMethodsPureParent::method().',
 				126,
 			],
-		];
-
-		if (PHP_VERSION_ID >= 80000) {
-			$errors[] = [
-				'Impure method Bug14563\ImpureTraitUser::pureTraitMethod() overrides pure method Bug14563\PureTrait::pureTraitMethod().',
-				147,
-			];
-		}
-
-		$errors = array_merge($errors, [
 			[
 				'Impure method Bug14563\ChildImpureOverridesPureExtended::pure() overrides pure method Bug14563\Foo::pure().',
-				158,
+				137,
 			],
 			[
 				'Impure method Bug14563\GrandchildImpureOverridesPure::pure() overrides pure method Bug14563\ChildPureOverridesPure::pure().',
-				169,
+				148,
 			],
 			[
 				'Impure method Bug14563\ImpureMultipleInterfaces::sharedMethod() overrides pure method Bug14563\PureInterfaceA::sharedMethod().',
-				207,
+				186,
 			],
 			[
 				'Impure method Bug14563\ImpureMultipleInterfaces::sharedMethod() overrides pure method Bug14563\PureInterfaceB::sharedMethod().',
-				207,
+				186,
 			],
 			[
 				'Impure method Bug14563\StaticChildImpureOverridesPure::pure() overrides pure method Bug14563\StaticFoo::pure().',
-				240,
+				219,
 			],
 			[
 				'Impure method Bug14563\StaticImpureImplementation::pureMethod() overrides pure method Bug14563\StaticPureInterface::pureMethod().',
-				291,
+				270,
+			],
+		]);
+	}
+
+	#[RequiresPhp('>= 8.0.0')]
+	public function testBug14563Trait(): void
+	{
+		$this->reportMaybes = true;
+		$this->reportStatic = true;
+		$this->analyse([__DIR__ . '/data/bug-14563-trait.php'], [
+			[
+				'Impure method Bug14563Trait\ImpureTraitUser::pureTraitMethod() overrides pure method Bug14563Trait\PureTrait::pureTraitMethod().',
+				19,
 			],
 		]);
-		$this->analyse([__DIR__ . '/data/bug-14563.php'], $errors);
 	}
 
 }

tests/PHPStan/Rules/Methods/data/bug-14563-trait.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14563Trait;
+
+trait PureTrait
+{
+
+	/** @phpstan-pure */
+	abstract public function pureTraitMethod(): int;
+
+}
+
+class ImpureTraitUser
+{
+
+	use PureTrait;
+
+	/** @phpstan-impure */
+	public function pureTraitMethod(): int
+	{
+		return random_int(0, 1);
+	}
+
+}

tests/PHPStan/Rules/Methods/data/bug-14563.php

@@ -130,27 +130,6 @@ public function method(): int
 
 }
 
-trait PureTrait
-{
-
-	/** @phpstan-pure */
-	abstract public function pureTraitMethod(): int;
-
-}
-
-class ImpureTraitUser
-{
-
-	use PureTrait;
-
-	/** @phpstan-impure */
-	public function pureTraitMethod(): int
-	{
-		return random_int(0, 1);
-	}
-
-}
-
 class ChildImpureOverridesPureExtended extends Foo
 {