-
Notifications
You must be signed in to change notification settings - Fork 8k
Update libtool to newer version #21067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This now comes with some extra files that libtool seems to need; normally aclocal handles this for you, but we don't use aclocal.
|
Nice work! I can't judge if this will give other side effect. But I can confirm that this will resolve the $PATH quotation issue. If merged PR #21065 will be obsolete. |
|
Hello, we can try updating this, yes. In my PR (#13476) I've tried to avoid having multiple libtool m4 files for simplicity - there they are merged into a single m4 file. Otherwise, scripts/phpize.m4 and scripts/phpize.in would also need to be adjusted for this a bit further. And, probably having some basic updating script for libtool would be useful probably here. Otherwise, another thing we can try here is to remove all libtool related files in php-src and use the |
Did it this way, since I want to keep closer to libtool upstream.
Working on a script to update autotools stuff. WRT last paragraph. if we do want to stop vendoring libtool, said script would be useful as a basis for how we want to invoke libtoolize. |
|
Can you please also mention in the final commit message some of these: And please rename the |
|
Here, I'd suggest to also recheck if these two code snippets |
Per https://autotools.info/autoconf/macros.html, the plural macro is only available is autoconf 2.70, whereas the previous one is in 2.58. We need to set it so that libtoolize copies things into the right place.
This doesn't seem to be necessary anymore: "Configuring libtool" output with
|
Splitting these out into a separate PR.
The version of libtool we're using is old enough to vote, and occasionally issues crop up related to it (i.e. this should fix GH-17310 incidentally). Update it to the latest version from upstream (serial 63 from 2.5.4). I don't believe we carry any patches that don't just replicate fixes in newer versions, so it should be OK to just use upstream's version. Newer libtool has more files that we have to include manually if not using aclocal, and some macro names were changed, so adapt to this.
Tested on linux/ppc64 and macos/arm64, with autoconf 2.72. I'm a little worried about the impact this might have on other platforms since this is a major bump. In particular, AIX might be turbulent, since library naming conventions changed a lot in libtool.