No exception on `mysqli::rollback` when transaction is no longer active

[mvorisek]

Description

Repro steps:

1. have an open mysqli connection
2. start transaction using mysqli::begin_transaction
3. run some query like analyze table xx, this is "administrative statement" [1] which implicit autocommit
4. rollback transaction using mysqli::rollback and notice no exception is thrown

Since PHP 8.0, PDO checks if a transaction is active and throws an exception: PDOException: There is no active transaction

mysqli must throw the same exception as well.

Related MariaDB tickets:

• https://jira.mariadb.org/browse/MDEV-28126
• https://jira.mariadb.org/browse/MDEV-32652

[1] docs https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html and repro: https://dbfiddle.uk/coUjimLq

PHP Version

7.4 - master

Operating System

any

[SakiTakamachi]

What is mysqli_driver::$report_mode? If MYSQLI_REPORT_STRICT, won't an exception occur?

[mvorisek]

What is mysqli_driver::$report_mode? If MYSQLI_REPORT_STRICT, won't an exception occur?

What is mysqli_driver class and how can I get mysqli_driver from mysqli connection?

Also MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT is the default mode since PHP 8.1 [1], thus I belive this this needs to be fixed in php-src.

[1] https://www.php.net/manual/en/mysqli-driver.report-mode.php

[SakiTakamachi]

The location where the exception was being thrown in PDO was different from what I expected. I created the PR.
#12579