From 2a4bb29e9c60ce4feaf54c9a6234e558d5b069a8 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 30 May 2026 22:51:26 +0200 Subject: [PATCH 1/2] benchmark: remove old alias usage in ffi benchmarks Follow-up to df09b2a48c2d7ec8. Refs: https://github.com/nodejs/node/pull/63482 Signed-off-by: Anna Henningsen --- benchmark/ffi/add-f64.js | 2 +- benchmark/ffi/add-i32.js | 2 +- benchmark/ffi/getpid.js | 2 +- benchmark/ffi/many-args.js | 2 +- benchmark/ffi/pointer-bigint.js | 2 +- benchmark/ffi/sum-buffer.js | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmark/ffi/add-f64.js b/benchmark/ffi/add-f64.js index fab6457e33a09d..e575a32e575661 100644 --- a/benchmark/ffi/add-f64.js +++ b/benchmark/ffi/add-f64.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - add_f64: { result: 'f64', parameters: ['f64', 'f64'] }, + add_f64: { result: 'f64', arguments: ['f64', 'f64'] }, }); const add = functions.add_f64; diff --git a/benchmark/ffi/add-i32.js b/benchmark/ffi/add-i32.js index bc8e2c4138080e..bfd571e521bb0d 100644 --- a/benchmark/ffi/add-i32.js +++ b/benchmark/ffi/add-i32.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - add_i32: { result: 'i32', parameters: ['i32', 'i32'] }, + add_i32: { result: 'i32', arguments: ['i32', 'i32'] }, }); const add = functions.add_i32; diff --git a/benchmark/ffi/getpid.js b/benchmark/ffi/getpid.js index c2e7d4ed89c34e..aa3c07d356efcb 100644 --- a/benchmark/ffi/getpid.js +++ b/benchmark/ffi/getpid.js @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, { }); const { lib, functions } = ffi.dlopen(null, { - uv_os_getpid: { result: 'i32', parameters: [] }, + uv_os_getpid: { result: 'i32', arguments: [] }, }); const getpid = functions.uv_os_getpid; diff --git a/benchmark/ffi/many-args.js b/benchmark/ffi/many-args.js index bacd873df52d1b..50038f29c031b0 100644 --- a/benchmark/ffi/many-args.js +++ b/benchmark/ffi/many-args.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - sum_6_i32: { result: 'i32', parameters: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] }, + sum_6_i32: { result: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] }, }); const fn = functions.sum_6_i32; diff --git a/benchmark/ffi/pointer-bigint.js b/benchmark/ffi/pointer-bigint.js index c44ef7f1656a0c..1700b2e9c481ed 100644 --- a/benchmark/ffi/pointer-bigint.js +++ b/benchmark/ffi/pointer-bigint.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - pointer_to_usize: { result: 'u64', parameters: ['pointer'] }, + pointer_to_usize: { result: 'u64', arguments: ['pointer'] }, }); const fn = functions.pointer_to_usize; diff --git a/benchmark/ffi/sum-buffer.js b/benchmark/ffi/sum-buffer.js index 3117f61aaedabf..6fa34509e2b86e 100644 --- a/benchmark/ffi/sum-buffer.js +++ b/benchmark/ffi/sum-buffer.js @@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - sum_buffer: { result: 'u64', parameters: ['pointer', 'u64'] }, + sum_buffer: { result: 'u64', arguments: ['pointer', 'u64'] }, }); function main({ n, size }) { From 1fbe68f1925e369cdfdb7e3746d9dac2f8d6b67b Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 31 May 2026 14:17:24 +0200 Subject: [PATCH 2/2] fixup! benchmark: remove old alias usage in ffi benchmarks Co-authored-by: Mert Can Altin Co-authored-by: Anna Henningsen --- benchmark/ffi/add-f64.js | 2 +- benchmark/ffi/add-i32.js | 2 +- benchmark/ffi/getpid.js | 2 +- benchmark/ffi/many-args.js | 2 +- benchmark/ffi/pointer-bigint.js | 2 +- benchmark/ffi/sum-buffer.js | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmark/ffi/add-f64.js b/benchmark/ffi/add-f64.js index e575a32e575661..f4e1dbac4ac3d4 100644 --- a/benchmark/ffi/add-f64.js +++ b/benchmark/ffi/add-f64.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - add_f64: { result: 'f64', arguments: ['f64', 'f64'] }, + add_f64: { return: 'f64', arguments: ['f64', 'f64'] }, }); const add = functions.add_f64; diff --git a/benchmark/ffi/add-i32.js b/benchmark/ffi/add-i32.js index bfd571e521bb0d..9a77a6f998f79d 100644 --- a/benchmark/ffi/add-i32.js +++ b/benchmark/ffi/add-i32.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - add_i32: { result: 'i32', arguments: ['i32', 'i32'] }, + add_i32: { return: 'i32', arguments: ['i32', 'i32'] }, }); const add = functions.add_i32; diff --git a/benchmark/ffi/getpid.js b/benchmark/ffi/getpid.js index aa3c07d356efcb..8008f407305e49 100644 --- a/benchmark/ffi/getpid.js +++ b/benchmark/ffi/getpid.js @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, { }); const { lib, functions } = ffi.dlopen(null, { - uv_os_getpid: { result: 'i32', arguments: [] }, + uv_os_getpid: { return: 'i32', arguments: [] }, }); const getpid = functions.uv_os_getpid; diff --git a/benchmark/ffi/many-args.js b/benchmark/ffi/many-args.js index 50038f29c031b0..bc269ace0c3e26 100644 --- a/benchmark/ffi/many-args.js +++ b/benchmark/ffi/many-args.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - sum_6_i32: { result: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] }, + sum_6_i32: { return: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] }, }); const fn = functions.sum_6_i32; diff --git a/benchmark/ffi/pointer-bigint.js b/benchmark/ffi/pointer-bigint.js index 1700b2e9c481ed..9ea01d28490e00 100644 --- a/benchmark/ffi/pointer-bigint.js +++ b/benchmark/ffi/pointer-bigint.js @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - pointer_to_usize: { result: 'u64', arguments: ['pointer'] }, + pointer_to_usize: { return: 'u64', arguments: ['pointer'] }, }); const fn = functions.pointer_to_usize; diff --git a/benchmark/ffi/sum-buffer.js b/benchmark/ffi/sum-buffer.js index 6fa34509e2b86e..60e25a85418565 100644 --- a/benchmark/ffi/sum-buffer.js +++ b/benchmark/ffi/sum-buffer.js @@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, { ensureFixtureLibrary(); const { lib, functions } = ffi.dlopen(libraryPath, { - sum_buffer: { result: 'u64', arguments: ['pointer', 'u64'] }, + sum_buffer: { return: 'u64', arguments: ['pointer', 'u64'] }, }); function main({ n, size }) {