From 56b17870d4d82375a0b2862a6de872c58082569f Mon Sep 17 00:00:00 2001 From: professional-slacker Date: Sat, 30 May 2026 08:01:32 +0900 Subject: [PATCH] deps: fix --no-string_slices flag being read-only Change DEFINE_BOOL_READONLY to DEFINE_BOOL so that the --no-string_slices V8 flag can be set at runtime. The flag was defined as read-only, making it impossible to disable string slices even though the code already contains fallback paths for when string_slices is false (factory.cc, builtins-string-gen.cc, code-stub-assembler.cc). The default value remains true, so there is no change in behavior for users who do not explicitly pass --no-string_slices. Refs: https://github.com/nicolo-ribaudo/v8/commit/1e2a395 --- deps/v8/src/flags/flag-definitions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index aab9435dbb53e5..f3d4453a745843 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -1085,7 +1085,7 @@ DEFINE_BOOL_READONLY(internalize_on_the_fly, true, // Flags for data representation optimizations DEFINE_BOOL(unbox_double_arrays, true, "automatically unbox arrays of doubles") -DEFINE_BOOL_READONLY(string_slices, true, "use string slices") +DEFINE_BOOL(string_slices, true, "use string slices") // Tiering: Sparkplug / feedback vector allocation. DEFINE_INT(invocation_count_for_feedback_allocation, 8,