deps: cherry-pick e807d4e379 from SQLite#63525
Conversation
|
Review requested:
|
louwers
left a comment
There was a problem hiding this comment.
We should just stick to the regular SQLite release cadence I think.
|
Thanks for reviewing, @louwers. I opened this PR because the disclosed HackerOne thread suggested that the If the project prefers to wait for the regular SQLite release cadence instead, |
There was a problem hiding this comment.
I'm agnostic towards merging, but we definitely shouldn't be regression testing on sqlite3's behalf, as it'll cause havoc with shared builds.
There was a problem hiding this comment.
Agreed, thanks. I pushed an update to skip this regression test when Node is
built with shared SQLite, so it only runs against the bundled SQLite copy that
this PR patches.
If you would prefer not to carry this SQLite regression test in Node at all,
I’m happy to remove it.
Backport the SQLite session extension fix for corrupt changesets that omit old values for primary-key columns. This avoids passing NULL to sessionBindValue() while applying UPDATE changesets. Refs: https://sqlite.org/src/info/e807d4e3798efd53 Signed-off-by: junius-sec <sksch323@naver.com>
0844bba to
f0cdb8e
Compare
Backport the SQLite session extension fix for malformed changesets that omit
old values for primary-key columns. The upstream fix avoids passing NULL to
sessionBindValue() while applying UPDATE changesets.
This adds a regression test for
DatabaseSync#applyChangeset()to verify thatthe malformed changeset returns
SQLITE_CORRUPTinstead of crashing.Refs: https://sqlite.org/src/info/e807d4e3798efd53
Refs: https://hackerone.com/reports/3736889
Tested on Linux x64: