quic: convert incoming :status header to number

Author: hallss93

doc/api/quic.md

@@ -3825,8 +3825,9 @@ A few things to note:
   the request is `HEADERS` followed by `END_STREAM`.
 * The `onheaders` callback receives the response pseudo-headers and
   regular headers in a single object with lowercase string keys.
-  After the callback returns, the same object is also accessible
-  via [`stream.headers`][].
+  For incoming headers, the `:status` pseudo-header is converted to
+  a `number`, matching HTTP/2 behavior. After the callback returns,
+  the same object is also accessible via [`stream.headers`][].
 * Reading `for await (const chunks of stream)` consumes the response
   body. Each iteration yields a `Uint8Array[]` batch of chunks.
 * HTTP semantic helpers (URL parsing, method/status validation,

lib/internal/quic/quic.js

@@ -1203,14 +1203,19 @@ function parseHeaderPairs(pairs) {
   assert(pairs.length % 2 === 0);
   const block = { __proto__: null };
   for (let n = 0; n + 1 < pairs.length; n += 2) {
-    if (block[pairs[n]] !== undefined) {
-      if (ArrayIsArray(block[pairs[n]])) {
-        ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
+    const name = pairs[n];
+    let value = pairs[n + 1];
+    // Match HTTP/2 behavior: incoming :status is exposed as a number.
+    if (name === ':status')
+      value |= 0;
+    if (block[name] !== undefined) {
+      if (ArrayIsArray(block[name])) {
+        ArrayPrototypePush(block[name], value);
       } else {
-        block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
+        block[name] = [block[name], value];
       }
     } else {
-      block[pairs[n]] = pairs[n + 1];
+      block[name] = value;
     }
   }
   return block;

test/parallel/test-quic-h3-callback-errors.mjs

@@ -154,7 +154,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
       ':authority': 'localhost',
     },
     onheaders: mustCall(function(headers) {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
     ontrailers: mustCall(function() {
       throw new Error('ontrailers sync error');
@@ -268,7 +268,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
       ':authority': 'localhost',
     },
     onheaders: mustCall(function(headers) {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 

test/parallel/test-quic-h3-close-behavior.mjs

@@ -65,7 +65,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall((headers) => {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 
@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall((headers) => {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 

test/parallel/test-quic-h3-concurrent-requests.mjs

@@ -75,7 +75,7 @@ const requests = paths.map(mustCall(async (path) => {
       ':authority': 'localhost',
     },
     onheaders: mustCall((headers) => {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
       headersReceived.resolve();
     }),
   });

test/parallel/test-quic-h3-datagram.mjs

@@ -90,7 +90,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall(function(headers) {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 
@@ -154,7 +154,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall((headers) => {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 

test/parallel/test-quic-h3-error-codes.mjs

@@ -58,7 +58,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall(function(headers) {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 
@@ -109,7 +109,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall(function(headers) {
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
     }),
   });
 

test/parallel/test-quic-h3-goaway.mjs

@@ -81,7 +81,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
   await clientSession.opened;
 
   const onClientHeaders = mustCall(function(headers) {
-    strictEqual(headers[':status'], '200');
+    strictEqual(headers[':status'], 200);
     if (++clientHeaderCount === 2) {
       bothHeadersReceived.resolve();
     }

test/parallel/test-quic-h3-header-validation.mjs

@@ -94,7 +94,7 @@ const decoder = new TextDecoder();
     },
     onheaders: mustCall(function(headers) {
       // Client should also receive lowercased response header names.
-      strictEqual(headers[':status'], '200');
+      strictEqual(headers[':status'], 200);
       strictEqual(headers['content-type'], 'text/html');
       strictEqual(headers['x-response-header'], 'ResponseValue');
 
@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
       ':authority': 'localhost',
     },
     onheaders: mustCall((headers) => {
-      strictEqual(headers[':status'], '204');
+      strictEqual(headers[':status'], 204);
     }),
   });
 

test/parallel/test-quic-h3-informational-headers.mjs

@@ -37,7 +37,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
   ok(msg.stream, 'stream.info should include stream');
   ok(msg.session, 'stream.info should include session');
   ok(msg.headers, 'stream.info should include headers');
-  strictEqual(msg.headers[':status'], '103');
+  strictEqual(msg.headers[':status'], 103);
 }));
 
 // quic.stream.headers also fires for the final response headers.
@@ -92,12 +92,12 @@ const stream = await clientSession.createBidirectionalStream({
     ':authority': 'localhost',
   },
   oninfo: mustCall(function(headers) {
-    strictEqual(headers[':status'], '103');
+    strictEqual(headers[':status'], 103);
     strictEqual(headers.link, '</style.css>; rel=preload; as=style');
     clientInfoReceived.resolve();
   }),
   onheaders: mustCall(function(headers) {
-    strictEqual(headers[':status'], '200');
+    strictEqual(headers[':status'], 200);
     strictEqual(headers['content-type'], 'text/plain');
     clientHeadersReceived.resolve();
   }),
@@ -110,7 +110,7 @@ const body = await bytes(stream);
 strictEqual(decoder.decode(body), responseBody);
 
 // stream.headers should return the final (initial) headers, not 1xx.
-strictEqual(stream.headers[':status'], '200');
+strictEqual(stream.headers[':status'], 200);
 
 await Promise.all([stream.closed, serverDone.promise]);
 await clientSession.close();