fixup! test_runner: match dotfiles in default coverage exclude

 Signed-off-by: semimikoh <ejffjeosms@gmail.com>

Author: semimikoh

lib/internal/fs/glob.js

@@ -927,13 +927,15 @@ class Glob {
  * @param {string} path the path to check
  * @param {string} pattern the glob pattern to match
  * @param {boolean} windows whether the path is on a Windows system, defaults to `isWindows`
+ * @param {object} [options] the options for the minimatch module
  * @returns {boolean}
  */
-function matchGlobPattern(path, pattern, windows = isWindows) {
+function matchGlobPattern(path, pattern, windows = isWindows, options = kEmptyObject) {
   validateString(path, 'path');
   validateString(pattern, 'pattern');
   return lazyMinimatch().minimatch(path, pattern, {
     kEmptyObject,
+    ...options,
     nocase: isMacOS || isWindows,
     windowsPathsNoEscape: true,
     nonegate: true,

lib/internal/test_runner/coverage.js

@@ -44,6 +44,11 @@ const kIgnoreRegex = /\/\* node:coverage ignore next (?<count>\d+ )?\*\//;
 const kLineEndingRegex = /\r?\n$/u;
 const kLineSplitRegex = /(?<=\r?\n)/u;
 const kStatusRegex = /\/\* node:coverage (?<status>enable|disable) \*\//;
+const kMatchGlobPatternOptions = { __proto__: null, dot: true };
+
+function matchCoverageGlob(path, pattern) {
+  return matchGlobPattern(path, pattern, undefined, kMatchGlobPatternOptions);
+}
 
 class CoverageLine {
   constructor(line, startOffset, src, length = src?.length) {
@@ -481,8 +486,8 @@ class TestCoverage {
     if (excludeGlobs?.length > 0) {
       for (let i = 0; i < excludeGlobs.length; ++i) {
         if (
-          matchGlobPattern(relativePath, excludeGlobs[i]) ||
-          matchGlobPattern(absolutePath, excludeGlobs[i])
+          matchCoverageGlob(relativePath, excludeGlobs[i]) ||
+          matchCoverageGlob(absolutePath, excludeGlobs[i])
         ) return true;
       }
     }
@@ -491,8 +496,8 @@ class TestCoverage {
     if (includeGlobs?.length > 0) {
       for (let i = 0; i < includeGlobs.length; ++i) {
         if (
-          matchGlobPattern(relativePath, includeGlobs[i]) ||
-          matchGlobPattern(absolutePath, includeGlobs[i])
+          matchCoverageGlob(relativePath, includeGlobs[i]) ||
+          matchCoverageGlob(absolutePath, includeGlobs[i])
         ) return false;
       }
       return true;

lib/internal/test_runner/utils.js

@@ -75,8 +75,6 @@ if (getOptionValue('--strip-types')) {
   ArrayPrototypePush(kFileExtensions, 'ts', 'mts', 'cts');
 }
 const kDefaultPattern = `**/{${ArrayPrototypeJoin(kPatterns, ',')}}.{${ArrayPrototypeJoin(kFileExtensions, ',')}}`;
-const kDefaultCoverageDotfilePattern =
-  `test/{.*,**/.*}.{${ArrayPrototypeJoin(kFileExtensions, ',')}}`;
 
 function createDeferredCallback() {
   let calledCount = 0;
@@ -405,7 +403,7 @@ function parseCommandLine() {
     if (!coverageExcludeGlobs || coverageExcludeGlobs.length === 0) {
       // TODO(pmarchini): this default should follow something similar to c8 defaults
       // Default exclusions should be also exported to be used by other tools / users
-      coverageExcludeGlobs = [kDefaultPattern, kDefaultCoverageDotfilePattern];
+      coverageExcludeGlobs = [kDefaultPattern];
     }
     coverageIncludeGlobs = getOptionValue('--test-coverage-include');