Skip to content

Commit 4a1150e

Browse files
authored
Merge pull request #14210 from microsoft/main
Merge to insiders -- this is to build a test vsix to confirm pipeline issues are resolved, not an actual release
2 parents 9b3b23f + a5d00e3 commit 4a1150e

File tree

10 files changed

+41
-20
lines changed

10 files changed

+41
-20
lines changed

Build/package/cpptools_extension_pack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ extends:
4444

4545
- template: /Build/package/jobs_package_vsix.yml@self
4646
parameters:
47-
vsixName: cpptools-extension-pack.vsix
47+
vsixName: cpptools-extension-pack
4848
srcDir: ExtensionPack

Build/package/cpptools_themes.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ extends:
4444

4545
- template: /Build/package/jobs_package_vsix.yml@self
4646
parameters:
47-
vsixName: cpptools-themes.vsix
47+
vsixName: cpptools-themes
4848
srcDir: Themes

Build/package/jobs_package_vsix.yml

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ parameters:
1111

1212
jobs:
1313
- job: package
14-
displayName: Build ${{ parameters.vsixName }}
14+
displayName: Build ${{ parameters.vsixName }}.vsix
1515
timeoutInMinutes: 30
1616
cancelTimeoutInMinutes: 1
1717
templateContext:
@@ -26,7 +26,7 @@ jobs:
2626
autoBaseline: false
2727
outputs:
2828
- output: pipelineArtifact
29-
displayName: '${{ parameters.vsixName }}'
29+
displayName: '${{ parameters.vsixName }}.vsix'
3030
targetPath: $(Build.ArtifactStagingDirectory)\vsix
3131
artifactName: vsix
3232

@@ -38,10 +38,8 @@ jobs:
3838
inputs:
3939
version: 22.x
4040

41-
- task: Npm@0
42-
displayName: Install vsce
43-
inputs:
44-
arguments: --global @vscode/vsce
41+
- script: npm install --global @vscode/vsce@3.1.1
42+
displayName: install vsce@3.1.1
4543

4644
- task: geeklearningio.gl-vsts-tasks-yarn.yarn-installer-task.YarnInstaller@3
4745
displayName: Use Yarn 1.x
@@ -51,11 +49,27 @@ jobs:
5149

5250
- script: |
5351
cd $(Build.SourcesDirectory)\${{ parameters.srcDir }}
54-
vsce package -o $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}
52+
vsce package -o $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}.vsix
5553
displayName: Run VSCE to package vsix
5654
57-
- task: Npm@0
58-
displayName: Uninstall vsce
55+
# sign the vsix
56+
- script: vsce generate-manifest -i $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}.vsix -o $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}.manifest
57+
displayName: generate manifest
58+
workingDirectory: $(Build.SourcesDirectory)\${{ parameters.srcDir }}
59+
- script: copy $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}.manifest $(Build.ArtifactStagingDirectory)\vsix\${{ parameters.vsixName }}.signature.p7s
60+
displayName: prepare manifest for signing
61+
workingDirectory: $(Build.SourcesDirectory)\${{ parameters.srcDir }}
62+
- task: NuGetToolInstaller@1
63+
displayName: Install NuGet
64+
- task: NuGetAuthenticate@1
65+
displayName: Authenticate NuGet
66+
- script: nuget restore $(Build.SourcesDirectory)\Build\signing\SignVsix.proj -PackagesDirectory $(Build.SourcesDirectory)\Build\signing\packages -ConfigFile $(Build.SourcesDirectory)\Build\signing\NuGet.config
67+
displayName: Restore MicroBuild Core
68+
- task: MSBuild@1
69+
displayName: Sign the vsix
5970
inputs:
60-
command: uninstall
61-
arguments: --global @vscode/vsce
71+
solution: $(Build.SourcesDirectory)\Build\signing\SignVsix.proj
72+
msbuildArguments: /p:SignType=${{ parameters.signType }}
73+
74+
- script: npm uninstall --global @vscode/vsce
75+
displayName: uninstall vsce

Build/publish/cpptools_extension_pack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ extends:
3939
jobs:
4040
- template: /Build/publish/jobs_publish_vsix.yml@self
4141
parameters:
42-
vsixName: cpptools-extension-pack.vsix
42+
vsixName: cpptools-extension-pack
4343

Build/publish/cpptools_themes.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ extends:
3939
jobs:
4040
- template: /Build/publish/jobs_publish_vsix.yml@self
4141
parameters:
42-
vsixName: cpptools-themes.vsix
42+
vsixName: cpptools-themes
4343

Build/publish/jobs_publish_vsix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
Write-Host "##vso[task.setvariable variable=AAD_TOKEN;issecret=true]$aadToken"
3838
3939
- script: |
40-
vsce publish --packagePath $(Build.StagingDirectory)\vsix\${{ parameters.vsixName }}
40+
npx @vscode/vsce@latest publish -i $(Build.StagingDirectory)\vsix\${{ parameters.vsixName }}.vsix --manifestPath $(Build.StagingDirectory)\vsix\${{ parameters.vsixName }}.manifest --signaturePath $(Build.StagingDirectory)\vsix\${{ parameters.vsixName }}.signature.p7s
4141
displayName: Publish to Marketplace
4242
env:
4343
VSCE_PAT: $(AAD_TOKEN)

Build/signing/NuGet.config

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<configuration>
3+
<packageSources>
4+
<clear />
5+
<add key="Engineering" value="https://pkgs.dev.azure.com/devdiv/_packaging/MicroBuildToolset/nuget/v3/index.json" />
6+
</packageSources>
7+
</configuration>

ExtensionPack/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
This extension pack includes a set of popular extensions for C++ development in Visual Studio Code:
44
* [C/C++](https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools)
55
* [C/C++ Themes](https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools-themes)
6-
* [C/C++ Dev Tools](https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpp-devtools)
6+
* [C/C++ DevTools](https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpp-devtools)
77
* [CMake Tools](https://marketplace.visualstudio.com/items?itemName=ms-vscode.cmake-tools)

ExtensionPack/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ExtensionPack/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"name": "Microsoft Corporation"
1010
},
1111
"license": "SEE LICENSE IN LICENSE.txt",
12-
"version": "1.5.0",
12+
"version": "1.5.1",
1313
"engines": {
1414
"vscode": "^1.48.0"
1515
},

0 commit comments

Comments
 (0)