Skip to content

[Experimental CMake Support Cherry-pick]: Embed cmake package definition for foun…#6435

Merged
ssparach merged 1 commit into
mainfrom
user/ssparach/cmake-on-main
May 4, 2026
Merged

[Experimental CMake Support Cherry-pick]: Embed cmake package definition for foun…#6435
ssparach merged 1 commit into
mainfrom
user/ssparach/cmake-on-main

Conversation

@ssparach
Copy link
Copy Markdown
Contributor

…dation package (#6361)

  • embed cmake in foundation package

  • Apply generalized cmake config feedback across component packages

  • Remove PACKAGE_VERSION (overlay-only concept, not needed when embedded)
  • Derive PACKAGE_LOCATION from CMAKE_CURRENT_LIST_DIR instead of global property
  • Add NuGetCMakePackage presence assertion with link to documentation
  • Replace inline platform detection with shared wasdk_detect_platform()
  • Replace inline XSLT manifest generation with shared wasdk_transform_appxfragment()
  • Replace explicit file listings with file(GLOB) for winmds, DLLs, and libs
  • Remove version-conditional dead code (ML, IXP)
  • Centralize NuGetCMakePackage guard into Base helpers
  • Move add_nuget_packages assertion to WindowsAppSDKHelpers.cmake (loaded by Base)
  • Update library URL to point to develop branch
  • Remove individual guard blocks from component configs (redundant with Base)
  • updates

  • make suggested changes

  • address feedback


A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

…dation package (#6361)

* embed cmake in foundation package

* Apply generalized cmake config feedback across component packages

- Remove PACKAGE_VERSION (overlay-only concept, not needed when embedded)
- Derive PACKAGE_LOCATION from CMAKE_CURRENT_LIST_DIR instead of global property
- Add NuGetCMakePackage presence assertion with link to documentation
- Replace inline platform detection with shared wasdk_detect_platform()
- Replace inline XSLT manifest generation with shared wasdk_transform_appxfragment()
- Replace explicit file listings with file(GLOB) for winmds, DLLs, and libs
- Remove version-conditional dead code (ML, IXP)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Centralize NuGetCMakePackage guard into Base helpers

- Move add_nuget_packages assertion to WindowsAppSDKHelpers.cmake (loaded by Base)
- Update library URL to point to develop branch
- Remove individual guard blocks from component configs (redundant with Base)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* updates

* make suggested changes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address feedback

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ssparach ssparach requested review from Scottj1s and agniuks April 29, 2026 16:48
@ssparach
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ssparach ssparach merged commit a75450c into main May 4, 2026
50 checks passed
@ssparach ssparach deleted the user/ssparach/cmake-on-main branch May 4, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants