Skip to content

Cleanup: CreateTestResult payload construction and minor typo in cmd #388

@PranjaliBhardwaj

Description

@PranjaliBhardwaj

I found the code in pkg/connectors/microcks_client.go and see that the CreateTestResult function is creating the JSON body using string concatenation. A little brittle and difficult to add more fields to the test request later on.

Also, I noticed that in cmd/cmd.go, the main entry point is called NewCommad (and not NewCommand).

I'm happy to put together a PR to:

Utilise a correct struct and json.Marshal test request payload.
Correct the typo in the NewCommad package and main.go in the CLI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions