Skip to content

There are no semicolons!!! #220

@t1r-endoh

Description

@t1r-endoh

(I`m japanese student, so please forgive my illegible English.)

Hi,

I`m trying to use micro-ROS with nucleo-f446re board.
When I build the package for STM32CubeIDE, I got these error.

I tried with this file↓
https://github.com/micro-ROS/micro_ros_stm32cubemx_utils#readme

/uros_ws/firmware/mcu_ws/uros/rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c: In function 'rmw_uros_set_custom_transport':
/uros_ws/firmware/mcu_ws/uros/rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c:44:5: error: implicit declaration of function 'RMW_UROS_TRACE_MESSAGE' [-Werror=implicit-function-declaration]
   44 |     RMW_UROS_TRACE_MESSAGE("Uninitialised arguments.")
      |     ^~~~~~~~~~~~~~~~~~~~~~
/uros_ws/firmware/mcu_ws/uros/rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c:44:55: error: expected ';' before 'return'
   44 |     RMW_UROS_TRACE_MESSAGE("Uninitialised arguments.")
      |                                                       ^
      |                                                       ;
   45 |     return RMW_RET_INVALID_ARGUMENT;
      |     ~~~~~~                                             
/uros_ws/firmware/mcu_ws/uros/rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c: In function 'rmw_uros_options_set_custom_transport':
/uros_ws/firmware/mcu_ws/uros/rmw_microxrcedds/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c:72:55: error: expected ';' before 'return'
   72 |     RMW_UROS_TRACE_MESSAGE("Uninitialised arguments.")
      |                                                       ^
      |                                                       ;
   73 |     return RMW_RET_INVALID_ARGUMENT;
      |     ~~~~~~                                             
cc1: some warnings being treated as errors
make[2]: *** [CMakeFiles/rmw_microxrcedds.dir/build.make:612: CMakeFiles/rmw_microxrcedds.dir/src/rmw_microros/custom_transport.c.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:81: CMakeFiles/rmw_microxrcedds.dir/all] Error 2
make: *** [Makefile:144: all] Error 2

I think this error is caused by this file.(44 line and 72 line)
https://github.com/micro-ROS/rmw_microxrcedds/blob/galactic/rmw_microxrcedds_c/src/rmw_microros/custom_transport.c
I checked other branches, and still no semicolons.
But there are no errors when I tried official tutorial.
https://micro.ros.org/docs/tutorials/core/first_application_rtos/
Are these specifications?

Thanks.

Ubuntu 20.04
STM32CubeIDE(latest)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions