Skip to content

Commit fdd626e

Browse files
authored
Update RemoteSigningWebhookEventHandler __repr__ (#71)
We shouldn't include the `master_seed` in the generated `__repr__` for `RemoteSigningWebhookEventHandler`, since folks probably aren't expecting it to be logged if they include their `RemoteSigningWebhookEventHandler` in a log.
1 parent 38c8ab5 commit fdd626e

2 files changed

Lines changed: 25 additions & 13 deletions

File tree

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Copyright ©, 2026-present, Lightspark Group, Inc. - All Rights Reserved
2+
3+
from lightspark import (
4+
LightsparkSyncClient,
5+
PositiveValidator,
6+
RemoteSigningWebhookEventHandler,
7+
)
8+
9+
10+
class TestRemoteSigning:
11+
def test_master_seed_not_in_repr(self) -> None:
12+
client = LightsparkSyncClient("", "")
13+
handler = RemoteSigningWebhookEventHandler(
14+
client=client,
15+
master_seed=b"1234",
16+
validator=PositiveValidator(),
17+
)
18+
19+
assert "1234" not in repr(handler)

lightspark/remote_signing.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from typing import Any
2-
from dataclasses import dataclass
2+
from dataclasses import dataclass, field
33
import json
44
import lightspark_crypto as lsc
55
import lightspark
@@ -14,21 +14,14 @@ def should_sign(webhook: Any) -> bool: # ty:ignore[invalid-method-override]
1414
@dataclass
1515
class RemoteSigningWebhookEventHandler:
1616
client: lightspark.LightsparkSyncClient
17-
master_seed: bytes
17+
master_seed: bytes = field(repr=False)
1818
validator: lsc.Validation
1919

20-
def __init__(
21-
self,
22-
client: lightspark.LightsparkSyncClient,
23-
master_seed: bytes,
24-
validator: lsc.Validation,
25-
):
26-
self.client = client
27-
self.master_seed = master_seed
28-
self.validator = validator
29-
3020
def handle_remote_signing_webhook_request(
31-
self, data: bytes, hexdigest: str, webhook_secret: str
21+
self,
22+
data: bytes,
23+
hexdigest: str,
24+
webhook_secret: str,
3225
):
3326
response = lsc.handle_remote_signing_webhook_event(
3427
data, hexdigest, webhook_secret, self.master_seed, self.validator

0 commit comments

Comments
 (0)