From 85c38cdf250c9be53804682ce58666d798fe6ea0 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Thu, 11 Jun 2026 11:12:14 -0400 Subject: [PATCH 1/2] Fix multisig miss accounting, comments. --- src/chasers/chaser_validate.cpp | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/chasers/chaser_validate.cpp b/src/chasers/chaser_validate.cpp index 2ca84052..d44592ed 100644 --- a/src/chasers/chaser_validate.cpp +++ b/src/chasers/chaser_validate.cpp @@ -356,24 +356,26 @@ code chaser_validate::validate(bool bypass, const chain::block& block, ////LOGA("Sigop @ " << ctx.height << " -> " //// << missed.to_string(chain::flags::all_rules)); }, - .fire = [&](signatures::miss miss) NOEXCEPT + .fire = [&](signatures::miss miss, size_t count) NOEXCEPT { switch (miss) { case signatures::miss::ecdsa: - ++missed_ecdsa_; + missed_ecdsa_ += count; ////fire(events::missed_ecdsa, ctx.height); break; case signatures::miss::multisig: - ++missed_multisig_; + missed_multisig_ += count; ////fire(events::missed_multisig, ctx.height); break; case signatures::miss::schnorr: - ++missed_schnorr_; + missed_schnorr_ += count; ////fire(events::missed_schnorr, ctx.height); break; case signatures::miss::overflow: - ++missed_threshold_; + // Misses overflow to single, so not called. + // This is instead used to reflect cache failure. + missed_threshold_ += count; ////fire(events::missed_overflow, ctx.height); break; @@ -438,10 +440,10 @@ code chaser_validate::validate(bool bypass, const chain::block& block, << "/(" << captured << "+" << missed << ")"); }; - log_capture("ecdsa.... ", ecdsa_, missed_ecdsa_); - log_capture("multisig. ", multisig_, missed_multisig_); - log_capture("schnorr.. ", schnorr_, missed_schnorr_); - log_capture("threshold ", threshold_,missed_threshold_); + log_capture("ecdsa.... ", ecdsa_, missed_ecdsa_); + log_capture("multisig. ", multisig_, missed_multisig_); + log_capture("schnorr.. ", schnorr_, missed_schnorr_); + log_capture("threshold ", threshold_, missed_threshold_); } else { From 96b03c076cc01d20648907395a211c4d9af87aa6 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Thu, 11 Jun 2026 11:13:11 -0400 Subject: [PATCH 2/2] Delint. --- src/chasers/chaser_validate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chasers/chaser_validate.cpp b/src/chasers/chaser_validate.cpp index d44592ed..c4b61c33 100644 --- a/src/chasers/chaser_validate.cpp +++ b/src/chasers/chaser_validate.cpp @@ -351,7 +351,7 @@ code chaser_validate::validate(bool bypass, const chain::block& block, // Enable/disable capture. .enabled = batch_signatures_, - .log = [&](const script& missed) NOEXCEPT + .log = [&](const script& ) NOEXCEPT { ////LOGA("Sigop @ " << ctx.height << " -> " //// << missed.to_string(chain::flags::all_rules));