From aa47aadf7a80208e289d06de9a6c99b890a539c1 Mon Sep 17 00:00:00 2001 From: KCM Date: Sat, 18 Apr 2026 14:44:27 -0500 Subject: [PATCH 1/3] test: webkit flake changes. --- playwright/helpers/app-test-helpers.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/playwright/helpers/app-test-helpers.ts b/playwright/helpers/app-test-helpers.ts index cfa8646..9224765 100644 --- a/playwright/helpers/app-test-helpers.ts +++ b/playwright/helpers/app-test-helpers.ts @@ -293,7 +293,15 @@ export const ensureDiagnosticsDrawerOpen = async (page: Page) => { const isExpanded = await toggle.getAttribute('aria-expanded') if (isExpanded !== 'true') { - await toggle.click() + try { + await toggle.click({ timeout: 2_000 }) + } catch { + /* WebKit can report pointer interception from the drawer during transitions. */ + await toggle.focus() + await page.keyboard.press('Enter') + } + + await expect(toggle).toHaveAttribute('aria-expanded', 'true') } await expect(page.getByRole('complementary', { name: 'Diagnostics' })).toBeVisible() From 62f8cb70ff60c71ace88b10f152ec0d6eac69985 Mon Sep 17 00:00:00 2001 From: KCM Date: Sat, 18 Apr 2026 14:51:43 -0500 Subject: [PATCH 2/3] refactor: workspaces coloring. --- src/styles/ai-controls.css | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/styles/ai-controls.css b/src/styles/ai-controls.css index 66e33e4..232a307 100644 --- a/src/styles/ai-controls.css +++ b/src/styles/ai-controls.css @@ -350,21 +350,22 @@ align-items: center; gap: 6px; margin-left: 2px; + --workspaces-toggle-color: color-mix(in srgb, #60a5fa 84%, var(--panel-text)); color: color-mix(in srgb, var(--panel-text) 84%, var(--text-subtle)); } .diagnostics-toggle.workspaces-toggle:hover:not(:disabled) { - color: color-mix(in srgb, var(--accent) 82%, var(--panel-text)); + color: var(--workspaces-toggle-color); } .workspaces-toggle__icon { width: 16px; height: 16px; - fill: currentColor; + fill: var(--workspaces-toggle-color); } .workspaces-toggle__icon path { - fill: currentColor; + fill: var(--workspaces-toggle-color); } .github-pr-context-close { From 341333fbe5bab6fc5e98452840ba97c82a31fc18 Mon Sep 17 00:00:00 2001 From: KCM Date: Sat, 18 Apr 2026 15:01:10 -0500 Subject: [PATCH 3/3] refactor: address pr comments. --- src/styles/ai-controls.css | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/styles/ai-controls.css b/src/styles/ai-controls.css index 232a307..e5271a2 100644 --- a/src/styles/ai-controls.css +++ b/src/styles/ai-controls.css @@ -351,6 +351,11 @@ gap: 6px; margin-left: 2px; --workspaces-toggle-color: color-mix(in srgb, #60a5fa 84%, var(--panel-text)); + --workspaces-toggle-color-disabled: color-mix( + in srgb, + var(--text-muted) 82%, + var(--panel-text) + ); color: color-mix(in srgb, var(--panel-text) 84%, var(--text-subtle)); } @@ -358,6 +363,13 @@ color: var(--workspaces-toggle-color); } +.diagnostics-toggle.workspaces-toggle:disabled { + opacity: 0.64; + cursor: not-allowed; + --workspaces-toggle-color: var(--workspaces-toggle-color-disabled); + color: color-mix(in srgb, var(--text-muted) 82%, var(--panel-text)); +} + .workspaces-toggle__icon { width: 16px; height: 16px;