`isEmpty()` throws when used on a `BigInt` type

[mesili]

Problem description

isEmpty() throws a Cannot convert a BigInt value to a number.

Related code

danfojs/src/danfojs-base/shared/utils.ts

Lines 93 to 95 in f272a7e

	isEmpty<T>(value: T): boolean {
	return value === undefined || value === null || (isNaN(value as any) && typeof value !== "string");
	}

Solution

Using isNaN(Number(value)) fixes the issue.

Discussion

Looking at the other isNaN() calls in said file it looks like some places are using Number(value) while some others don't.
I suspect some other methods would throw in the same way.

[glennj]

If it's a BigInt, does that automatically mean not empty? This is how I patched it

$ diff -u node_modules/danfojs-node/dist/danfojs-base/shared/utils.js{.orig,}
--- node_modules/danfojs-node/dist/danfojs-base/shared/utils.js.orig    2024-12-12 15:00:44.148829969 -0500
+++ node_modules/danfojs-node/dist/danfojs-base/shared/utils.js 2024-12-12 14:59:54.343042712 -0500
@@ -108,6 +108,7 @@
      * @returns
      */
     Utils.prototype.isEmpty = function (value) {
+        if (typeof value === "bigint") return false;
         return value === undefined || value === null || (isNaN(value) && typeof value !== "string");
     };
     /**