Upgrading to 1.7.6 broke creation of rpm and AppImage installers

[sivanxpeer]

[fvarrui]

🤨

[Lanode]

Hi. I don't know if this is right issue to write about, but i have similar problem and don't want to make new unnecessary issues.
So, I discovered when i try to make AppImage because of default configuration packaging process throw an error about not finding an appimagetool in assets:

Error log

[INFO]     Generating AppImage...
[INFO]         Getting appimagetool...
[WARNING]         Failed to download the file. Response code: 404
[INFO]         File downloaded from [https://github.com/AppImage/AppImageKit/releases/download/13/appimagetool-x86_64.AppImage] to [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool]
[INFO]         App image tool found! /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool
[INFO]         Copying folder content [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Copying file [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava.desktop] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava.desktop /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin/AmerecoLauncherJava.desktop
[INFO]         Copying folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/libs] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' -R /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/libs /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin
[INFO]         Copying file [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin/AmerecoLauncherJava
[INFO]         Copying folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/jre] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' -R /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/jre /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin
[INFO]         Copying file [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava.png] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava/AmerecoLauncherJava.png /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/usr/bin/AmerecoLauncherJava.png
[INFO]         Desktop file rendered in /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/AmerecoLauncherJava.desktop
[INFO]         Creating AppRun symlink to startup script...
[INFO]         Creating symbolic link [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/AppRun] to [usr/bin/AmerecoLauncherJava]
[INFO]         Copying icon to AppDir ...
[INFO]         Copying file [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AmerecoLauncherJava.png] to folder [/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir]
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && 'cp' /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AmerecoLauncherJava.png /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir/AmerecoLauncherJava.png
[INFO]         Running appimagetool on /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava
[INFO]         Executing command: /bin/sh -c cd '/home/lanode/NetBeansProjects/AmerecoLauncher/.' && '/home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool' --appimage-extract-and-run /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava.AppImage
[ERROR]         /bin/sh: строка 1: /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool: Нет такого файла или каталога
[ERROR]     AppImage generation failed due to: Command execution failed: /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool --appimage-extract-and-run /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava.AppImage
[ERROR] 
org.codehaus.plexus.util.cli.CommandLineException: Command execution failed: /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/appimagetool --appimage-extract-and-run /home/lanode/NetBeansProjects/AmerecoLauncher/target/assets/AppDir /home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava.AppImage
    at io.github.fvarrui.javapackager.utils.CommandUtils.executeOnDirectory (CommandUtils.java:20)
    at io.github.fvarrui.javapackager.utils.CommandUtils.execute (CommandUtils.java:30)
    at io.github.fvarrui.javapackager.utils.CommandUtils.execute (CommandUtils.java:26)
    at io.github.fvarrui.javapackager.packagers.GenerateAppImage.doApply (GenerateAppImage.java:78)
    at io.github.fvarrui.javapackager.packagers.GenerateAppImage.doApply (GenerateAppImage.java:13)
    at io.github.fvarrui.javapackager.packagers.ArtifactGenerator.apply (ArtifactGenerator.java:44)
    at io.github.fvarrui.javapackager.packagers.Packager.generateInstallers (Packager.java:439)
    at io.github.fvarrui.javapackager.maven.PackageMojo.execute (PackageMojo.java:394)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
[INFO]     
[INFO] Installers generated! [/home/lanode/NetBeansProjects/AmerecoLauncher/target/AmerecoLauncherJava_1.0-SNAPSHOT.deb]

Then I went to GenerateAppImage.java and saw a link that doesn't work. By going through this link i saw an obsolete message in releases of AppImageTool that said

Obsolete version. DO NOT USE THIS VERSION ANYMORE.

Please switch to the new version at
https://github.com/AppImage/appimagetool/releases/tag/continuous

So i think you need to update a link to appimagetool downloads like this

private static final String IMAGETOOL_URL = "https://github.com/AppImage/appimagetool/releases/download/" + IMAGETOOL_VERSION + "/appimagetool-%s.AppImage";

or like this to have continuous build

private static final String IMAGETOOL_URL = "https://github.com/AppImage/appimagetool/releases/download/continuous/appimagetool-%s.AppImage";

[ghc001-code]

When can we expect a release that includes this fix? Is there a workaround in the meantime? Thanks

[ilacc1]

So this is a nasty one because it creates a hardcoded dependency on something external which is a moving target. Can we add configuration option for this URL instead of the hardcoded value?