Skip to content

feature/custom-component add custom component render and classNames#106

Closed
dmitrykuznetsovdev wants to merge 1 commit into
igorprado:masterfrom
dmitrykuznetsovdev:feature/custom-component
Closed

feature/custom-component add custom component render and classNames#106
dmitrykuznetsovdev wants to merge 1 commit into
igorprado:masterfrom
dmitrykuznetsovdev:feature/custom-component

Conversation

@dmitrykuznetsovdev

Copy link
Copy Markdown

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 95.62% when pulling c4cae1c on batmandarkside:feature/custom-component into f7ad149 on igorprado:master.

@MomchilGorchev MomchilGorchev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really valid use case

@nandastone

nandastone commented Feb 8, 2018

Copy link
Copy Markdown

imo the component isn't complete without the ability to override the display component. There's no way to add supporting content or use custom CSS.

Can we get this or #54 merged, and if not some guidance on what first needs to be fixed?

@nandastone

Copy link
Copy Markdown

I'm using a hacky solution for replacing just the internal elements of the modal (not the wrapper or modal item).

Pass through the real content via the children prop, and hide the default elements:

children: (
  <div className='new-content'>
    <h4 className='new-title'>{title}</h4>
    <div className='new-message'>{message}</div>
  </div>
)
.notification-title,
.notification-message,
.notification-dismiss { display: none; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants