Skip to content

Footnotes implementation#78

Open
ralsina wants to merge 2 commits into
icyleaf:masterfrom
ralsina:footnotes
Open

Footnotes implementation#78
ralsina wants to merge 2 commits into
icyleaf:masterfrom
ralsina:footnotes

Conversation

@ralsina

@ralsina ralsina commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

This is, AFAIK a full implementation of footnotes as per the specs we have on the repo.

@trafico-bot trafico-bot Bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Mar 7, 2025
@icyleaf icyleaf mentioned this pull request Mar 9, 2025
7 tasks
@ralsina ralsina force-pushed the footnotes branch 2 times, most recently from d9a392d to ac17b63 Compare March 13, 2025 23:21
@ralsina ralsina changed the title WIP: Footnotes implementation Basic Footnotes implementation Mar 13, 2025
@trafico-bot trafico-bot Bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Mar 13, 2025
@ralsina ralsina marked this pull request as ready for review March 14, 2025 17:39
@nobodywasishere

Copy link
Copy Markdown
Collaborator

If this is in a stable place, I'm fine to merge this now and sort out the issues in followup PRs.

@ralsina

ralsina commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

It implements some basic cases and doesn't seem to break anything at least :-)

@ralsina

ralsina commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

I am working now on finishing this.

@ralsina ralsina changed the title Basic Footnotes implementation Footnotes implementation Feb 15, 2026
@ralsina

ralsina commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Weird, tests were passing before, fixing.

@ralsina

ralsina commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

Sigh, I asked the LLM to fix ameba warnings and it choose wrong on every one of them. Fixed now :-)

@nobodywasishere

nobodywasishere commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

Wonder if the .claude and .vscode folders should be in the .gitignore - how are other projects handling these?

Edit: Same with CLAUDE.md and the like

Comment thread src/markd/parsers/block.cr
@ralsina

ralsina commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Wonder if the .claude and .vscode folders should be in the .gitignore - how are other projects handling these?

Edit: Same with CLAUDE.md and the like

Deleted and ignored.

@ralsina ralsina closed this Feb 23, 2026
@ralsina ralsina reopened this Feb 23, 2026
@ralsina

ralsina commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

I can't spend any more time working on this PR.

@nobodywasishere

Copy link
Copy Markdown
Collaborator

I can carry it from here if you want.

@ralsina

ralsina commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

I can carry it from here if you want.

That would be great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔍 Ready for Review Pull Request is not reviewed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants