GHCommitPointer throws NPE on null repository

[rnveach]

Describe the bug

I receive an NPE on GHCommitPointer#getCommit because getRepository() returns null.

I assume getRepository() should always be populated as I need a GHRepository to even get the initial PR/issue in the first place.

To Reproduce

While scanning https://github.com/checkstyle/checkstyle/pulls , I pick up PR 1.
I call GHPullRequest#getHead() and get the GHCommitPointer.
I call GHCommitPointer#getCommit() and receive an NPE.
getRepository() returns null.

Expected behavior

No NPE.

Additional context

GHPullRequest#getBase() doesn't seem to have this issue.

[rnveach]

@bitwiseman Can you explain how repo is normally populated? I assume there is reflection going on here as there is no setter or assignment.

github-api/src/main/java/org/kohsuke/github/GHCommitPointer.java

Line 46 in e14ec3b

private GHRepository repo;

[bitwiseman]

@rnveach
https://github.com/FasterXML/jackson populating from JSON to objects.

[n09tal]

Hi, I submitted a fix proposal for this issue here:
#2265

Summary:

• Added null check in GHCommitPointer#getCommit
• Added regression test GHCommitPointerTest#nullRepoNpe
• Verified targeted test passes