From f2417ead7f1759130e7b044af2d146e8f94ecd56 Mon Sep 17 00:00:00 2001 From: Eddie A Tejeda <669988+eddietejeda@users.noreply.github.com> Date: Wed, 8 Jul 2026 13:59:32 -0700 Subject: [PATCH] docs: remove internal service references from changelog and test docstrings This is a generic client library; issue references and service names from private infrastructure do not belong in its public history-facing text. --- CHANGELOG.md | 2 +- tests/test_errors.py | 3 +-- tests/test_managed_client.py | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 02a7585..022e715 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- `ManagedDatabaseClient.fetch_table` now carries the `X-Database-Id` scope header on the result poll, the query-run poll, and the Arrow fetch — not only on the query submit. Results of database-scoped queries are themselves database-scoped, so every read against an existing synced table (merge/append loads, dlt state restore) failed with `400: Bad Request` once the table had data (dlthubworker#70). +- `ManagedDatabaseClient.fetch_table` now carries the `X-Database-Id` scope header on the result poll, the query-run poll, and the Arrow fetch — not only on the query submit. Results of database-scoped queries are themselves database-scoped, so every read against an existing synced table (merge/append loads, dlt state restore) failed with `400: Bad Request` once the table had data. - API error messages now include the response body (flattened, truncated to 500 chars). `400: Bad Request` alone hid the server's actual explanation. ### Changed diff --git a/tests/test_errors.py b/tests/test_errors.py index ed344af..3094187 100644 --- a/tests/test_errors.py +++ b/tests/test_errors.py @@ -1,8 +1,7 @@ """Error message construction: the API's response body must survive. "400: Bad Request" alone is undebuggable; the body carries the server's -actual explanation (e.g. which header was missing). Regression for the -opaque load failures in dlthubworker#70. +actual explanation (e.g. which header was missing). """ from __future__ import annotations diff --git a/tests/test_managed_client.py b/tests/test_managed_client.py index 964f812..260d67c 100644 --- a/tests/test_managed_client.py +++ b/tests/test_managed_client.py @@ -107,8 +107,7 @@ def test_fetch_table_carries_database_scope_on_result_reads( hotdata 0.6.0 SDK exposes ``x_database_id`` on all three. Regression: reruns/append loads against an existing synced table failed - with an opaque ``400: Bad Request`` (dlthubworker#70) because both reads - omitted the scope. + with an opaque ``400: Bad Request`` because both reads omitted the scope. """ result_scopes: list[str | None] = [] arrow_scopes: list[str | None] = []