Skip to content

Commit f2417ea

Browse files
committed
docs: remove internal service references from changelog and test docstrings
This is a generic client library; issue references and service names from private infrastructure do not belong in its public history-facing text.
1 parent 72b0dc2 commit f2417ea

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212

1313
### Fixed
1414

15-
- `ManagedDatabaseClient.fetch_table` now carries the `X-Database-Id` scope header on the result poll, the query-run poll, and the Arrow fetch — not only on the query submit. Results of database-scoped queries are themselves database-scoped, so every read against an existing synced table (merge/append loads, dlt state restore) failed with `400: Bad Request` once the table had data (dlthubworker#70).
15+
- `ManagedDatabaseClient.fetch_table` now carries the `X-Database-Id` scope header on the result poll, the query-run poll, and the Arrow fetch — not only on the query submit. Results of database-scoped queries are themselves database-scoped, so every read against an existing synced table (merge/append loads, dlt state restore) failed with `400: Bad Request` once the table had data.
1616
- API error messages now include the response body (flattened, truncated to 500 chars). `400: Bad Request` alone hid the server's actual explanation.
1717

1818
### Changed

tests/test_errors.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
"""Error message construction: the API's response body must survive.
22
33
"400: Bad Request" alone is undebuggable; the body carries the server's
4-
actual explanation (e.g. which header was missing). Regression for the
5-
opaque load failures in dlthubworker#70.
4+
actual explanation (e.g. which header was missing).
65
"""
76

87
from __future__ import annotations

tests/test_managed_client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ def test_fetch_table_carries_database_scope_on_result_reads(
107107
hotdata 0.6.0 SDK exposes ``x_database_id`` on all three.
108108
109109
Regression: reruns/append loads against an existing synced table failed
110-
with an opaque ``400: Bad Request`` (dlthubworker#70) because both reads
111-
omitted the scope.
110+
with an opaque ``400: Bad Request`` because both reads omitted the scope.
112111
"""
113112
result_scopes: list[str | None] = []
114113
arrow_scopes: list[str | None] = []

0 commit comments

Comments
 (0)