fix csv parser when no separator detected#131
Open
SaInekK wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
convert_text_to_instrumentspreviously calledpd.read_csv(sep=None)for CSV files where no separator was detected. On pandas ≥ 2.3 this raises (the auto-detection branch was removed). This change guards the CSV-parse block withcsv_sep is not None, so files with no detectable separator fall through to the txt branch instead of raising.Fixes # (no upstream issue raised — happy to file one if you'd like a tracker)
Type of change
Testing
pytest tests/→ passes; restores the 6test_remove_*_digits_from_csvtests that fail onmainunder pandas 2.3+.Test Configuration
Checklist