Skip to content

Fix edge-case bug in "Issue Trigger" workflow#8635

Open
t-will-gillis wants to merge 1 commit into
hackforla:gh-pagesfrom
t-will-gillis:fix-bug-issue-trigger-8634
Open

Fix edge-case bug in "Issue Trigger" workflow#8635
t-will-gillis wants to merge 1 commit into
hackforla:gh-pagesfrom
t-will-gillis:fix-bug-issue-trigger-8634

Conversation

@t-will-gillis
Copy link
Copy Markdown
Member

@t-will-gillis t-will-gillis commented May 10, 2026

Fixes #8634

What changes did you make?

  • In preliminary-update-comment.js added filter to remove PRs

Why did you make the changes (we will use this info to test)?

  • We need to ensure that only issues are returned in the query so that if a dev assign themselves to their own PR, the results do not include it- this will cause GraphQL to return an error and the automation checks will fail.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • BEFORE condition, test logs
    • In my personal repo. Note that I assigned my repo's PR 1311 to myself
    • I then assigned my repo's issue 1309 to myself, triggering the "Issue Trigger" workflow and the step "Ask-For-Preliminary-Update". This result in a failure of the workflow.
    • This duplicates the existing edge case failure: Could not resolve to an issue with the number of 1311. because the 1311 is a PR, not an issue.
  • AFTER condition, test logs
    • The AFTER branch includes the line that adds })).data.filter(issue => !issue.pull_request); to preliminary-update-comment.js
    • Same setup as before: PR 1311 still assigned to self, and triggered workflow by self-assigning issue 1309.
    • Results show that the PR is not included in the list of issues assigned, and therefore the automation can run as expected.

@github-actions github-actions Bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms labels May 10, 2026
@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-fix-bug-issue-trigger-8634 gh-pages
git pull https://github.com/t-will-gillis/website.git fix-bug-issue-trigger-8634

@github-actions github-actions Bot added the size: 5pt Can be done in 19-30 hours label May 10, 2026
@mocodesss mocodesss requested review from moazDev1 and mocodesss and removed request for moazDev1 May 11, 2026 23:29
@mocodesss
Copy link
Copy Markdown
Member

mocodesss commented May 11, 2026

ETA: 5/16 EOD
Availability: Tuesday am, Tuesday evening, Thursday am, Weekend at various times

@santi-jose
Copy link
Copy Markdown
Member

ETA: 5/15/26 7PM
Availability: Monday - Friday: 6:00 - 8:00PM

@mocodesss
Copy link
Copy Markdown
Member

Thank you for this PR @t-will-gillis. I apologized for the delayed review. In looking at this, I can see the change to the filter in preliminary-update-comment.js and can see that here are image links in this PR, I assume, "...demonstrating that this solution returns only issues, and not PRs, and that the automation functions correctly with this change," as the issue asks, but those images are not working. Are they working for you? Or, can you repost those images?

@t-will-gillis
Copy link
Copy Markdown
Member Author

Hi @mocodesss (and @santi-jose)-

Thank you, you are correct for calling this out: I neglected to post the tests showing workflow runs before and after the change. These are now included in the summary.

Please let me know if you have questions, or if you would like to take a deeper dive into GHAs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Fix bug in "Issue Trigger" causing an edge-case failure at the dev multi-issue assignment check

3 participants