Fix edge-case bug in "Issue Trigger" workflow#8635
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 5/16 EOD |
|
ETA: 5/15/26 7PM |
|
Thank you for this PR @t-will-gillis. I apologized for the delayed review. In looking at this, I can see the change to the filter in preliminary-update-comment.js and can see that here are image links in this PR, I assume, "...demonstrating that this solution returns only issues, and not PRs, and that the automation functions correctly with this change," as the issue asks, but those images are not working. Are they working for you? Or, can you repost those images? |
|
Hi @mocodesss (and @santi-jose)- Thank you, you are correct for calling this out: I neglected to post the tests showing workflow runs before and after the change. These are now included in the summary. Please let me know if you have questions, or if you would like to take a deeper dive into GHAs. |
Fixes #8634
What changes did you make?
preliminary-update-comment.jsadded filter to remove PRsWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Could not resolve to an issue with the number of 1311.because the 1311 is a PR, not an issue.})).data.filter(issue => !issue.pull_request);topreliminary-update-comment.js