gnd: Improvements thread

[dimitrovmaksim]

I'll add issues that I find as different comments, so I don't flood the repo

[dimitrovmaksim]

There are several places where the manifest is loaded directly with serde_yaml instead through the load_manifest() function from manifest.rs.
Some of them may be intentional, but maybe worth checking.

  add.rs                                                                                                                                             
                                                                                                                                                     
  Line 84-85: Loading manifest to extract network           
  let manifest: serde_yaml::Value = serde_yaml::from_str(&manifest_content)
      .with_context(|| format!("Failed to parse manifest: {}", opt.manifest.display()))?;

  Line 372-373: In update_manifest function
  let mut manifest: serde_yaml::Value =
      serde_yaml::from_str(&content).context("Failed to parse manifest")?;

  build.rs

  Line 489: In create_ipfs_manifest function (no .context() but direct ?)
  let mut value: serde_yaml::Value = serde_yaml::from_str(&manifest_str)?;

  Line 751: In write_output_manifest function (no .context() but direct ?)
  let mut value: serde_yaml::Value = serde_yaml::from_str(&manifest_str)?;

  Line 895-896: In apply_network_to_manifest function
  let mut manifest: serde_yaml::Value = serde_yaml::from_str(&manifest_str)
      .with_context(|| format!("Failed to parse manifest: {}", manifest_path.display()))?;

  init.rs

  Line 908: In init_from_subgraph function
  let manifest: serde_yaml::Value =
      serde_yaml::from_str(&manifest_yaml).context("Failed to parse subgraph manifest YAML")?;

Some of the cases and also the load_manifest function uses .with_context(), but only the context is printed and the underlying error is silenced, because the error are printed with {}.

gnd build  
→ Load subgraph from subgraph.yaml
Error: Failed to parse manifest: "subgraph.yaml"

[dimitrovmaksim]

This is probably more of graph-node related issue, because gnd uses the graph-node manifest validation, but the error are returned one-by-one (if there are multiple missing fields for example) which may annoy developers:

 $ gnd build
→ Load subgraph from subgraph.yaml
Error: Failed to parse manifest: "subgraph.yaml": parse error: missing field `file`: missing field `file`

$ graph build                              
✔ Apply migrations
✖ Failed to load subgraph from subgraph.yaml: Error in subgraph.yaml:

  Path: dataSources > 0 > mapping > abis > 0 > file
  No value provided

  Path: dataSources > 1 > source > abi
  No value provided