Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

JavaScript CreateFixture method no longer accesses global world variable...#51

Open
zilluss wants to merge 2 commits into
google:masterfrom
zilluss:fix-js-global-var
Open

JavaScript CreateFixture method no longer accesses global world variable...#51
zilluss wants to merge 2 commits into
google:masterfrom
zilluss:fix-js-global-var

Conversation

@zilluss

@zilluss zilluss commented Apr 26, 2015

Copy link
Copy Markdown

This fixes the problem from #49 and adds a GetWorld method to b2Body.

@zilluss

zilluss commented Apr 26, 2015

Copy link
Copy Markdown
Author

The compiled JavaScript files need to be updated by someone else, because my version of emcc creates a ~30kB larger output file and an additional .mem file.

@EJTH

EJTH commented Apr 27, 2015

Copy link
Copy Markdown

Somebody give this guy a medal, and get this merged into the repo please!

@zilluss

zilluss commented Apr 27, 2015

Copy link
Copy Markdown
Author

You can get the version I compiled here https://gist.githubusercontent.com/zilluss/ccdf2c17c2d8577ea4dc/raw/14deed4733a4e3798c0993b07e0d76c8671f59ff/liquidfun.js

But as I said, it's a bit larger. The new emcc also fixes #50 partially, so the lengths of positionBuffer/particleCount match, so you don't get problems when rendering them as GL_POINTS. But CreateParticle still creates some strange particles that behave like b2_staticBodies :(

@EJTH

EJTH commented Jan 11, 2016

Copy link
Copy Markdown

So, is there any chance of this getting merged?

@stewartmiles

Copy link
Copy Markdown
Contributor

Thanks, though this now needs to be rebased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants