Added basic frame for packfile implementation and testing, as well as the testing of the corresponding PackedDB. It wants to be filled out now, but the design not yet done either actually

Author: Byron

db/pack.py

@@ -4,8 +4,41 @@
 						ObjectDBR
 				)
 
+from gitdb.exc import (
+							UnsupportedOperation,
+						)
+
 __all__ = ('PackedDB', )
 
 class PackedDB(FileDBBase, ObjectDBR):
 	"""A database operating on a set of object packs"""
 
+	def __init__(self, root_path):
+		super(PackedDB, self).__init__(root_path)
+		
+	
+	#{ Object DB Read 
+	
+	def has_object(self, sha):
+		raise NotImplementedError()
+		
+	def info(self, sha):
+		raise NotImplementedError()
+	
+	def stream(self, sha):
+		raise NotImplementedError()
+	
+	#} END object db read
+	
+	#{ object db write
+	
+	def store(self, istream):
+		"""Storing individual objects is not feasible as a pack is designed to 
+		hold multiple objects. Writing or rewriting packs for single objects is
+		inefficient"""
+		raise UnsupportedOperation()
+		
+	def store_async(self, reader):
+		raise NotImplementedError()
+	
+	#} END object db write

exc.py

@@ -12,3 +12,5 @@ class BadObject(ODBError):
 class BadObjectType(ODBError):
 	"""The object had an unsupported type"""
 
+class UnsupportedOperation(ODBError):
+	"""Thrown if the given operation cannot be supported by the object database"""

pack.py

@@ -0,0 +1 @@
+"""Contains PackIndex and PackFile implementations"""

test/db/lib.py

@@ -1,6 +1,7 @@
 """Base classes for object db testing"""
 from gitdb.test.lib import (
 	with_rw_directory,
+	with_packs,
 	ZippedStoreShaWriter,
 	TestBase
 	)
@@ -16,11 +17,10 @@
 from gitdb.typ import str_blob_type
 
 from async import IteratorReader
-
 from cStringIO import StringIO
 
 
-__all__ = ('TestDBBase', 'with_rw_directory' )
+__all__ = ('TestDBBase', 'with_rw_directory', 'with_packs' )
 
 class TestDBBase(TestBase):
 	"""Base class providing testing routines on databases"""

test/db/test_pack.py

@@ -0,0 +1,12 @@
+from lib import *
+from gitdb.db import PackedDB
+		
+class TestPackDB(TestDBBase):
+	
+	@with_rw_directory
+	@with_packs
+	def test_writing(self, path):
+		ldb = PackedDB(path)
+		# TODO
+		
+	

test/fixtures/packs/pack-11fdfa9e156ab73caae3b6da867192221f2089c2.idx

@@ -10,6 +10,7 @@
 from array import array
 from cStringIO import StringIO
 
+import glob
 import unittest
 import tempfile
 import shutil
@@ -46,10 +47,46 @@ def wrapper(self):
 	return wrapper
 
 
+def with_packs(func):
+	"""Function that provides a path into which the packs for testing should be 
+	copied. Will pass on the path to the actual function afterwards"""
+	def wrapper(self, path):
+		src_pack_glob = fixture_path('packs/*')
+		copy_files_globbed(src_pack_glob, path, hard_link_ok=True)
+		return func(self, path)
+	# END wrapper
+	
+	wrapper.__name__ = func.__name__
+	return wrapper
+
 #} END decorators
 
 #{ Routines
 
+def fixture_path(relapath=''):
+	""":return: absolute path into the fixture directory
+	:param relapath: relative path into the fixtures directory, or ''
+		to obtain the fixture directory itself"""
+	return os.path.join(os.path.dirname(__file__), 'fixtures', relapath)
+	
+def copy_files_globbed(source_glob, target_dir, hard_link_ok=False):
+	"""Copy all files found according to the given source glob into the target directory
+	:param hard_link_ok: if True, hard links will be created if possible. Otherwise 
+		the files will be copied"""
+	for src_file in glob.glob(source_glob):
+		if hard_link_ok and hasattr(os, 'link'):
+			target = os.path.join(target_dir, os.path.basename(src_file))
+			try:
+				os.link(src_file, target)
+			except OSError:
+				shutil.copy(src_file, target_dir)
+			# END handle cross device links ( and resulting failure )
+		else:
+			shutil.copy(src_file, target_dir)
+		# END try hard link
+	# END for each file to copy
+	
+
 def make_bytes(size_in_bytes, randomize=False):
 	""":return: string with given size in bytes
 	:param randomize: try to produce a very random stream"""

test/fixtures/packs/pack-11fdfa9e156ab73caae3b6da867192221f2089c2.pack

@@ -0,0 +1,16 @@
+"""Test everything about packs reading and writing"""
+
+from lib import (
+					TestBase,
+					with_rw_directory, 
+					with_packs
+				)
+					
+
+class TestPack(TestBase):
+	
+	@with_rw_directory
+	@with_packs
+	def test_reading(self, pack_dir):
+		# initialze a pack file for reading
+		pass