Merge pull request #4359 from github/copilot/fix-unit-test-errors-koffy-upgrade

cklin · web-flow · commit a0e327b841b7 · 2026-04-07T12:27:27.000-07:00
Fix off-by-one in expandShortPathNative truncating last path character on Windows
diff --git a/extensions/ql-vscode/src/common/short-paths.ts b/extensions/ql-vscode/src/common/short-paths.ts
@@ -170,7 +170,7 @@ async function expandShortPathNative(shortPath: string, logger: BaseLogger) {
     throw new Error("Failed to get long path name");
   }
 
-  const longPath = buffer.toString("utf16le", 0, (result - 1) * 2);
+  const longPath = buffer.toString("utf16le", 0, result * 2);
 
   void logger.log(`Expanded short path ${shortPath} to ${longPath}`);
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ async function expandShortPathNative(shortPath: string, logger: BaseLogger) {`
`170`	`170`	`throw new Error("Failed to get long path name");`
`171`	`171`	`}`
`172`	`172`
`173`		`- const longPath = buffer.toString("utf16le", 0, (result - 1) * 2);`
	`173`	`+ const longPath = buffer.toString("utf16le", 0, result * 2);`
`174`	`174`
`175`	`175`	void logger.log(`Expanded short path ${shortPath} to ${longPath}`);
`176`	`176`