Skip to content

Commit 3aaeb68

Browse files
committed
Rust: Make the new test inline expectations.
1 parent e8923b7 commit 3aaeb68

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
query: queries/summary/CryptographicOperations.ql
2+
postprocess:
3+
- utils/test/InlineExpectationsTestQuery.ql

rust/ql/test/query-tests/security/CWE-327/WeakSensitiveDataHashing/test.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ fn test_hash_algorithms(
1616
_ = md5::Md5::digest(encrypted_password);
1717

1818
// MD5 (alternative / older library)
19-
_ = md5_alt::compute(harmless);
20-
_ = md5_alt::compute(credit_card_no); // $ Alert[rust/weak-sensitive-data-hashing]
21-
_ = md5_alt::compute(password); // $ Alert[rust/weak-sensitive-data-hashing]
22-
_ = md5_alt::compute(encrypted_password);
19+
_ = md5_alt::compute(harmless); // $ Alert[rust/summary/cryptographic-operations]
20+
_ = md5_alt::compute(credit_card_no); // $ Alert[rust/summary/cryptographic-operations] Alert[rust/weak-sensitive-data-hashing]
21+
_ = md5_alt::compute(password); // $ Alert[rust/summary/cryptographic-operations] Alert[rust/weak-sensitive-data-hashing]
22+
_ = md5_alt::compute(encrypted_password); // $ Alert[rust/summary/cryptographic-operations]
2323

2424
// SHA-1
2525
_ = sha1::Sha1::digest(harmless);
@@ -64,14 +64,14 @@ fn test_hash_code_patterns(
6464
_ = md5::Md5::digest(password_vec); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
6565

6666
// hash through a hasher object
67-
let mut md5_hasher = md5::Md5::new();
67+
let mut md5_hasher = md5::Md5::new(); // $ Alert[rust/summary/cryptographic-operations]
6868
md5_hasher.update(b"abc");
6969
md5_hasher.update(harmless);
7070
md5_hasher.update(password); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
7171
_ = md5_hasher.finalize();
7272

73-
_ = md5::Md5::new().chain_update(harmless).chain_update(harmless).chain_update(harmless).finalize();
74-
_ = md5::Md5::new().chain_update(harmless).chain_update(password).chain_update(harmless).finalize(); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
73+
_ = md5::Md5::new().chain_update(harmless).chain_update(harmless).chain_update(harmless).finalize(); // $ Alert[rust/summary/cryptographic-operations]
74+
_ = md5::Md5::new().chain_update(harmless).chain_update(password).chain_update(harmless).finalize(); // $ Alert[rust/summary/cryptographic-operations] MISSING: Alert[rust/weak-sensitive-data-hashing]
7575

7676
_ = md5::Md5::new_with_prefix(harmless).finalize();
7777
_ = md5::Md5::new_with_prefix(password).finalize(); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
@@ -130,7 +130,7 @@ fn test_hash_structs() {
130130
let str3c = serde_urlencoded::to_string(&s3).unwrap();
131131

132132
// hash with MD5
133-
let mut md5_hasher = md5::Md5::new();
133+
let mut md5_hasher = md5::Md5::new(); // $ Alert[rust/summary/cryptographic-operations]
134134
md5_hasher.update(s1.data);
135135
md5_hasher.update(s2.credit_card_no); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
136136
md5_hasher.update(s3.password); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
@@ -153,7 +153,7 @@ fn test_hash_file(
153153
let mut harmless_file = std::fs::File::open(harmless_filename).unwrap();
154154
let mut password_file = std::fs::File::open(password_filename).unwrap();
155155

156-
let mut md5_hasher = md5::Md5::new();
156+
let mut md5_hasher = md5::Md5::new(); // $ Alert[rust/summary/cryptographic-operations]
157157
_ = std::io::copy(&mut harmless_file, &mut md5_hasher);
158158
_ = std::io::copy(&mut password_file, &mut md5_hasher); // $ MISSING: Alert[rust/weak-sensitive-data-hashing]
159159
_ = md5_hasher.finalize();

0 commit comments

Comments
 (0)