Skip to content

Commit 567ca73

Browse files
committed
Address review comments
1 parent 5f3f250 commit 567ca73

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

.github/workflows/rebuild.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ jobs:
3434
with:
3535
node-version: 24
3636
cache: 'npm'
37+
cache-dependency-path: |
38+
package-lock.json
39+
pr-checks/package-lock.json
3740
3841
- name: Remove label
3942
if: github.event_name == 'pull_request'
@@ -55,11 +58,16 @@ jobs:
5558
git fetch origin "$BASE_BRANCH"
5659
5760
# Allow merge conflicts in `lib`, since rebuilding should resolve them.
58-
if git merge "origin/$BASE_BRANCH"; then
59-
MERGE_RESULT=0
61+
git merge "origin/$BASE_BRANCH"
62+
MERGE_RESULT=$?
63+
64+
if [ "$MERGE_RESULT" -eq 0 ]; then
65+
echo "Merge succeeded cleanly."
66+
elif [ "$MERGE_RESULT" -eq 1 ]; then
67+
echo "Merge conflicts detected (exit code $MERGE_RESULT), continuing."
6068
else
61-
MERGE_RESULT=$?
62-
echo "Merge conflicts detected, continuing."
69+
echo "git merge failed with unexpected exit code $MERGE_RESULT."
70+
exit 1
6371
fi
6472
6573
if [ "$MERGE_RESULT" -ne 0 ]; then

0 commit comments

Comments
 (0)