From 5f8c882948d2db72f9db0b5e03e61f70e6aa8e68 Mon Sep 17 00:00:00 2001 From: Md Ferdous Alam Date: Mon, 23 Feb 2026 14:54:55 +0600 Subject: [PATCH] merge-base, ls-remote, ls-tree: fix error message formatting The CodingGuidelines state that error messages should not begin with a capital letter and should not end with a full stop. Fix the die() messages in builtin/merge-base.c, builtin/ls-remote.c, and builtin/ls-tree.c that violate these rules. Signed-off-by: Md Ferdous Alam --- builtin/ls-remote.c | 2 +- builtin/ls-tree.c | 2 +- builtin/merge-base.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c index fe77829557f252..51d7579ca126c9 100644 --- a/builtin/ls-remote.c +++ b/builtin/ls-remote.c @@ -128,7 +128,7 @@ int cmd_ls_remote(int argc, if (!remote) { if (dest) die("bad repository '%s'", dest); - die("No remote configured to list refs from."); + die("no remote configured to list refs from"); } if (get_url) { diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c index 113e4a960dc7dd..7670aa77a3ebc0 100644 --- a/builtin/ls-tree.c +++ b/builtin/ls-tree.c @@ -406,7 +406,7 @@ int cmd_ls_tree(int argc, usage_with_options(ls_tree_usage, ls_tree_options); if (repo_get_oid_with_flags(the_repository, argv[0], &oid, GET_OID_HASH_ANY)) - die("Not a valid object name %s", argv[0]); + die("not a valid object name %s", argv[0]); /* * show_recursive() rolls its own matching code and is diff --git a/builtin/merge-base.c b/builtin/merge-base.c index c7ee97fa6ac62a..e337f283f729ff 100644 --- a/builtin/merge-base.c +++ b/builtin/merge-base.c @@ -47,10 +47,10 @@ static struct commit *get_commit_reference(const char *arg) struct commit *r; if (repo_get_oid(the_repository, arg, &revkey)) - die("Not a valid object name %s", arg); + die("not a valid object name %s", arg); r = lookup_commit_reference(the_repository, &revkey); if (!r) - die("Not a valid commit name %s", arg); + die("not a valid commit name %s", arg); return r; } @@ -131,7 +131,7 @@ static int handle_fork_point(int argc, const char **argv) commitname = (argc == 2) ? argv[1] : "HEAD"; if (repo_get_oid(the_repository, commitname, &oid)) - die("Not a valid object name: '%s'", commitname); + die("not a valid object name: '%s'", commitname); derived = lookup_commit_reference(the_repository, &oid);