This PR is to add comments to GetPersistentVolumeName in pkg/ddc/base/pv.go#5931
Conversation
|
Hi @jerry-njucs. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
|
|
👋 DCO check failed for this PR (action_required). Please ensure all commits include the |
|
DCO check failed. Please ensure all commits have the |
Signed-off-by: Jerry <231220060@smail.nju.edu.cn>
|
|
DCO has been fixed. Please review again, thanks! |
|
/lgtm |
|
@cheyang The E2E check needs a maintainer's approval to run. Could you please take a look? Thanks! |
cheyang
left a comment
There was a problem hiding this comment.
All CI checks passed and maintainer has approved. Auto-approving to satisfy branch protection.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5931 +/- ##
=======================================
Coverage 63.35% 63.35%
=======================================
Files 481 481
Lines 33070 33070
=======================================
Hits 20953 20953
Misses 10442 10442
Partials 1675 1675 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Ⅰ. Describe what this PR does
This PR adds a // style comment for the function GetPersistentVolumeName in fluid/pkg/ddc/base/pv.go.
The comment explains:
Ⅱ. Does this pull request fix one issue?
fixes #5930