Skip to content

This PR is to add comments to GetPersistentVolumeName in pkg/ddc/base/pv.go#5931

Merged
cheyang merged 1 commit into
fluid-cloudnative:masterfrom
jerry-njucs:new-branch
Jun 8, 2026
Merged

This PR is to add comments to GetPersistentVolumeName in pkg/ddc/base/pv.go#5931
cheyang merged 1 commit into
fluid-cloudnative:masterfrom
jerry-njucs:new-branch

Conversation

@jerry-njucs

Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR adds a // style comment for the function GetPersistentVolumeName in fluid/pkg/ddc/base/pv.go.

The comment explains:

  • The function's purpose: returning the PersistentVolume name associated with the runtime info
  • The name format: namespace-name

Ⅱ. Does this pull request fix one issue?

fixes #5930

@fluid-e2e-bot

fluid-e2e-bot Bot commented May 30, 2026

Copy link
Copy Markdown

Hi @jerry-njucs. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a descriptive comment to the GetPersistentVolumeName function in pkg/ddc/base/pv.go explaining its purpose and naming format. There are no review comments, and I have no feedback to provide.

@cheyang

cheyang commented May 30, 2026

Copy link
Copy Markdown
Collaborator

/ok-to-test

@cheyang

cheyang commented May 30, 2026

Copy link
Copy Markdown
Collaborator

⚠️ DCO 检查未通过 — 此 PR 的提交缺少正确的 DCO (Developer Certificate of Origin) 签名。请在每个 commit 中添加 Signed-off-by: Your Name <your@email> 行,可通过 git commit --amend --signoff 修复后 force push。

@cheyang

cheyang commented May 31, 2026

Copy link
Copy Markdown
Collaborator

👋 DCO check failed for this PR (action_required). Please ensure all commits include the Signed-off-by: Name <email> line. You can fix this by amending your commits with git commit --amend --signoff and force-pushing.

@cheyang

cheyang commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

DCO check failed. Please ensure all commits have the Signed-off-by: trailer. You can fix this by amending your commits with git commit --amend -s and force-pushing.

Signed-off-by: Jerry <231220060@smail.nju.edu.cn>
@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

@jerry-njucs

Copy link
Copy Markdown
Contributor Author

DCO has been fixed. Please review again, thanks!

@cheyang

cheyang commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@jerry-njucs

Copy link
Copy Markdown
Contributor Author

@cheyang The E2E check needs a maintainer's approval to run. Could you please take a look? Thanks!

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI checks passed and maintainer has approved. Auto-approving to satisfy branch protection.

@fluid-e2e-bot

fluid-e2e-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.35%. Comparing base (823e07e) to head (9cab0d9).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5931   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files         481      481           
  Lines       33070    33070           
=======================================
  Hits        20953    20953           
  Misses      10442    10442           
  Partials     1675     1675           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheyang cheyang merged commit d49322a into fluid-cloudnative:master Jun 8, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to GetPersistentVolumeName in pkg/ddc/base/pv.go.

2 participants