fix: improve type safety and error handling#1819
Open
N3XT3R1337 wants to merge 2 commits intofastapi:mainfrom
Open
fix: improve type safety and error handling#1819N3XT3R1337 wants to merge 2 commits intofastapi:mainfrom
N3XT3R1337 wants to merge 2 commits intofastapi:mainfrom
Conversation
svlandeg
reviewed
Mar 18, 2026
| return kwarg_value | ||
| config_class_value = new_cls.model_config.get(name, Undefined) | ||
| if config_class_value is not Undefined: | ||
| return config_class_value |
Member
There was a problem hiding this comment.
Please explain why this was moved
svlandeg
reviewed
Mar 18, 2026
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
This looks like it's (probably) a legitimate bug fix, but could you provide more information in the PR description? Currently it says
Improvements found during code review: added type annotations, improved error handling, fixed edge cases. All existing tests pass.
which doesn't seem to fit the actuall diff.
Author
|
Thanks for the review! This change moves the config_class_value check earlier in the resolution order, so that model_config values take precedence over default field values. Without this, a field default could shadow an explicitly set config value. Happy to add tests or adjust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements found during code review: added type annotations, improved error handling, fixed edge cases. All existing tests pass.