Fix TSAN data races in InspectorFlags and InspectorPackagerConnection (#56534)#56534
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Fix TSAN data races in InspectorFlags and InspectorPackagerConnection (#56534)#56534javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101809616. |
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D101809616
branch
from
ecd5c35 to
bd0175d
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 22, 2026
…facebook#56534) Summary: Fix two ThreadSanitizer data races caught by the messenger_demo integration test under dev-tsan mode. **InspectorFlags**: `loadFlagsAndAssertUnchanged()` reads and writes `cachedValues_` without synchronization. The main thread calls it via `getIsProfilingBuild()` while the JS thread calls it via `getNetworkInspectionEnabled()`, racing on the shared `optional<Values>`. Add a `std::mutex` to protect `cachedValues_` access. The lock is taken after computing `newValues` from feature flags, so flag reads stay outside the critical section. **InspectorPackagerConnection**: `Impl::connect()` is called from the main thread but accesses `webSocket_` which is also read by `didFailWithError()` on the inspector thread. Dispatch the body of `connect()` to the inspector thread via `scheduleCallback()`, matching the pattern `reconnect()` already uses. Changelog: [Internal] Differential Revision: D101809616
javache
force-pushed
the
export-D101809616
branch
from
bd0175d to
3218ed5
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 24, 2026
…facebook#56534) Summary: Fix two ThreadSanitizer data races caught by the messenger_demo integration test under dev-tsan mode. **InspectorFlags**: `loadFlagsAndAssertUnchanged()` reads and writes `cachedValues_` without synchronization. The main thread calls it via `getIsProfilingBuild()` while the JS thread calls it via `getNetworkInspectionEnabled()`, racing on the shared `optional<Values>`. Add a `std::mutex` to protect `cachedValues_` access. The lock is taken after computing `newValues` from feature flags, so flag reads stay outside the critical section. `dangerouslyResetFlags()` also acquires the lock to avoid racing with concurrent flag reads. **Inspector**: `Inspector::connectDebugger()` is called from the main thread but creates and uses `packagerConnection_` which is also accessed on the inspector thread. Dispatch the body of `connectDebugger()` to the task dispatch thread via `invokeElsePost()`, matching the pattern other Inspector methods already use. This ensures `InspectorPackagerConnection::connect()` is called on the correct thread as its API requires. Changelog: [Internal] Differential Revision: D101809616
javache
force-pushed
the
export-D101809616
branch
from
3218ed5 to
d5cf4cf
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 27, 2026
…facebook#56534) Summary: Pull Request resolved: facebook#56534 Fix two ThreadSanitizer data races caught by the messenger_demo integration test under dev-tsan mode. **InspectorFlags**: `loadFlagsAndAssertUnchanged()` reads and writes `cachedValues_` without synchronization. The main thread calls it via `getIsProfilingBuild()` while the JS thread calls it via `getNetworkInspectionEnabled()`, racing on the shared `optional<Values>`. Add a `std::mutex` to protect `cachedValues_` access. The lock is taken after computing `newValues` from feature flags, so flag reads stay outside the critical section. `dangerouslyResetFlags()` also acquires the lock to avoid racing with concurrent flag reads. **Inspector**: `Inspector::connectDebugger()` is called from the main thread but creates and uses `packagerConnection_` which is also accessed on the inspector thread. Dispatch the body of `connectDebugger()` to the task dispatch thread via `invokeElsePost()`, matching the pattern other Inspector methods already use. This ensures `InspectorPackagerConnection::connect()` is called on the correct thread as its API requires. Changelog: [Internal] Differential Revision: D101809616
…facebook#56534) Summary: Fix two ThreadSanitizer data races caught by the messenger_demo integration test under dev-tsan mode. **InspectorFlags**: `loadFlagsAndAssertUnchanged()` reads and writes `cachedValues_` without synchronization. The main thread calls it via `getIsProfilingBuild()` while the JS thread calls it via `getNetworkInspectionEnabled()`, racing on the shared `optional<Values>`. Add a `std::mutex` to protect `cachedValues_` access. The lock is taken after computing `newValues` from feature flags, so flag reads stay outside the critical section. `dangerouslyResetFlags()` also acquires the lock to avoid racing with concurrent flag reads. **Inspector**: `Inspector::connectDebugger()` is called from the main thread but creates and uses `packagerConnection_` which is also accessed on the inspector thread. Dispatch the body of `connectDebugger()` to the task dispatch thread via `invokeElsePost()`, matching the pattern other Inspector methods already use. This ensures `InspectorPackagerConnection::connect()` is called on the correct thread as its API requires. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D101809616
|
This pull request has been merged in 86dbb3b. |
Collaborator
|
This pull request was successfully merged by @javache in 86dbb3b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix two ThreadSanitizer data races caught by the messenger_demo integration test under dev-tsan mode.
InspectorFlags:
loadFlagsAndAssertUnchanged()reads and writescachedValues_without synchronization. The main thread calls it viagetIsProfilingBuild()while the JS thread calls it viagetNetworkInspectionEnabled(), racing on the sharedoptional<Values>. Add astd::mutexto protectcachedValues_access. The lock is taken after computingnewValuesfrom feature flags, so flag reads stay outside the critical section.dangerouslyResetFlags()also acquires the lock to avoid racing with concurrent flag reads.Inspector:
Inspector::connectDebugger()is called from the main thread but creates and usespackagerConnection_which is also accessed on the inspector thread. Dispatch the body ofconnectDebugger()to the task dispatch thread viainvokeElsePost(), matching the pattern other Inspector methods already use. This ensuresInspectorPackagerConnection::connect()is called on the correct thread as its API requires.Changelog: [Internal]
Reviewed By: hoxyq
Differential Revision: D101809616