Skip to content

Sync prime factors#969

Merged
mk-mxp merged 9 commits into
exercism:mainfrom
Narkunan:sync-prime-factors
May 24, 2026
Merged

Sync prime factors#969
mk-mxp merged 9 commits into
exercism:mainfrom
Narkunan:sync-prime-factors

Conversation

@Narkunan
Copy link
Copy Markdown
Contributor

Fix #959

@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp self-requested a review May 24, 2026 08:43
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels May 24, 2026
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny issues, nothing functional. Thanks for helping!

Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
Comment thread exercises/practice/prime-factors/PrimeFactorsTest.php Outdated
@Narkunan
Copy link
Copy Markdown
Contributor Author

@mk-mxp My blenders I did not noticed the method names. You can review them.

@Narkunan Narkunan requested a review from mk-mxp May 24, 2026 13:09
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping!

@mk-mxp mk-mxp merged commit 958ba1f into exercism:main May 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync prime-factors

2 participants