Skip to content

Commit 34a8ab1

Browse files
authored
Merge pull request #172 from krassowski/fix-ghost-reviewer-issue
Fix reviews from users removed from GitHub breaking generation
2 parents 24db8fe + f4170e1 commit 34a8ab1

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

github_activity/graphql.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,9 +344,13 @@ def get_reviewers(reviews):
344344
"""map review graph to unique list of reviewers"""
345345
if pd.isna(reviews) or not reviews:
346346
return []
347-
return sorted(
348-
set([review["node"]["author"]["login"] for review in reviews["edges"]])
349-
)
347+
reviewers = {
348+
review["node"]["author"]["login"]
349+
for review in reviews["edges"]
350+
if review.get("node", {}).get("author")
351+
and review["node"]["author"].get("login")
352+
}
353+
return sorted(reviewers)
350354

351355
self.data["reviewers"] = self.data["reviews"].map(get_reviewers)
352356

0 commit comments

Comments
 (0)